This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Add notification for track added to playlist#1512
Merged
Merged
Conversation
added 2 commits
June 23, 2022 16:48
5c78d1f to
1d9f12d
Compare
ed07bfc to
c8b2954
Compare
Collaborator
|
Preview this change https://demo.audius.co/is-add-track-to-playlist-notif |
c8b2954 to
566c329
Compare
Collaborator
|
Preview this change https://demo.audius.co/is-add-track-to-playlist-notif |
dylanjeffers
approved these changes
Jun 27, 2022
dylanjeffers
left a comment
Contributor
There was a problem hiding this comment.
looks awesome, nice job handling v1 and v2 notifs for native too
Collaborator
|
Preview this change https://demo.audius.co/is-add-track-to-playlist-notif |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a new notification for when a user has their track added to a playlist.
Identity changes: https://github.com/AudiusProject/audius-protocol/commits/master
Completes PLAT-134.
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
Tested against staging and hardcoded a response from identity with a notification
Simulator.Screen.Recording.-.iPhone.13.-.2022-06-23.at.16.10.29.mp4
Simulator.Screen.Recording.-.iPhone.13.-.2022-06-23.at.13.24.12.mp4
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.