Skip to content
This repository was archived by the owner on Oct 4, 2023. It is now read-only.

Add notification for track added to playlist#1512

Merged
isaacsolo merged 6 commits into
mainfrom
is-add-track-to-playlist-notif
Jun 27, 2022
Merged

Add notification for track added to playlist#1512
isaacsolo merged 6 commits into
mainfrom
is-add-track-to-playlist-notif

Conversation

@isaacsolo

@isaacsolo isaacsolo commented Jun 23, 2022

Copy link
Copy Markdown

Description

Adds a new notification for when a user has their track added to a playlist.

Identity changes: https://github.com/AudiusProject/audius-protocol/commits/master

Completes PLAT-134.

Dragons

Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Tested against staging and hardcoded a response from identity with a notification

      notifications.notifications.unshift({
        id: '6c3ec116-224c-436b-8bee-95ec840341c3',
        isHidden: false,
        isRead: false,
        isViewed: true,
        timestamp: '2022-06-10T18:19:32.000Z',
        type: 'AddTrackToPlaylist',
        playlistId: 1400,
        playlistOwnerId: 38872,
        trackId: 20998
      })
Simulator.Screen.Recording.-.iPhone.13.-.2022-06-23.at.16.10.29.mp4
Simulator.Screen.Recording.-.iPhone.13.-.2022-06-23.at.13.24.12.mp4

Screen Shot 2022-06-22 at 6 26 09 PM

How will this change be monitored?

For features that are critical or could fail silently please describe the monitoring/alerting being added.

@isaacsolo isaacsolo force-pushed the is-add-track-to-playlist-notif branch from 5c78d1f to 1d9f12d Compare June 24, 2022 00:24
@isaacsolo isaacsolo force-pushed the is-add-track-to-playlist-notif branch from ed07bfc to c8b2954 Compare June 24, 2022 01:58
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/is-add-track-to-playlist-notif

@isaacsolo isaacsolo requested a review from dylanjeffers June 24, 2022 02:55
@isaacsolo isaacsolo force-pushed the is-add-track-to-playlist-notif branch from c8b2954 to 566c329 Compare June 24, 2022 02:55
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/is-add-track-to-playlist-notif

@dylanjeffers dylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks awesome, nice job handling v1 and v2 notifs for native too

Comment thread packages/mobile/src/screens/notifications-screen/content/AddTrackToPlaylist.tsx Outdated
Comment thread packages/mobile/src/screens/notifications-screen/content/AddTrackToPlaylist.tsx Outdated
Comment thread packages/mobile/src/screens/notifications-screen/content/AddTrackToPlaylist.tsx Outdated
@audius-infra

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/is-add-track-to-playlist-notif

@isaacsolo isaacsolo merged commit 4c8454f into main Jun 27, 2022
@isaacsolo isaacsolo deleted the is-add-track-to-playlist-notif branch June 27, 2022 17:18
@raymondjacobson raymondjacobson mentioned this pull request Jul 6, 2022
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
@AudiusProject AudiusProject deleted a comment from linear Bot Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants