This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[PAY-186] Address desktop notification qa#1312
Merged
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/dj-pay-186-desktop-notification-qa |
rickyrombo
approved these changes
May 13, 2022
|
|
||
| const users = useSelector((state: CommonState) => | ||
| getNotificationUsers(state, notificationProp, USER_LENGTH_LIMIT) | ||
| getNotificationUsers(state, notificationProp, USER_LENGTH_LIMIT + 3) |
Contributor
Author
There was a problem hiding this comment.
Omg great catch, that was a test
| const otherUsersCount = otherUsers.length | ||
| const isMultiUser = users.length > 1 | ||
| const { users, userIds, timeLabel, isRead } = notification | ||
| const [firstUser] = users |
Contributor
There was a problem hiding this comment.
This is cool - we don't need otherUsers anymore!
Contributor
Author
There was a problem hiding this comment.
Yeah realized that couldn't be relied on since we only pull 8 users max, so need the ids from the actual notif to know the true number of users
Contributor
There was a problem hiding this comment.
Wait but should it be const otherUsersCount = userIds.length - 1 below? Won't this double count the first user?
Contributor
Author
There was a problem hiding this comment.
Yup nice catch
Merged
dylanjeffers
added a commit
that referenced
this pull request
May 18, 2022
This reverts commit 72a4025.
raymondjacobson
pushed a commit
that referenced
this pull request
May 19, 2022
This reverts commit 72a4025.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes various notification qa issues: