This repository was archived by the owner on Oct 4, 2023. It is now read-only.
Revert "Remove tik tok feature flag"#1307
Merged
Merged
Conversation
This reverts commit d3df9a8.
dylanjeffers
approved these changes
May 11, 2022
dylanjeffers
left a comment
Contributor
There was a problem hiding this comment.
Nice, so are there cases where we have tiktok stuff still around that isn't actually relying on the feature? like i know share modals maybe?
Contributor
Author
What do you mean by 'relying on the feature'? The feature flag? All the UI is gated behind the flag afaik |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit d3df9a8.
Description
Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.