This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-475] Fix RemixesScreen header text alignment#1303
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/dj-c-475-fix-remixes-screen-header-text |
0395867 to
5925aed
Compare
Collaborator
|
Preview this change https://demo.audius.co/dj-c-475-fix-remixes-screen-header-text |
sliptype
approved these changes
May 11, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Nice work!
Interesting about Pressable vs Text, although I think eventually we might want active styling on everything pressable
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue where long titles mess up RemixesScreen text wrapping
Before:
After:
Learned that Pressable has a bug where it doesn't align well with text, the suggested workaround is to just use the onPress on Text components since we don't care about onPresIn, onPressOut: https://stackoverflow.com/questions/66590167/vertically-align-pressable-inside-a-text-component