This repository was archived by the owner on Oct 4, 2023. It is now read-only.
c-456 Fix pending tx every session load#1293
Merged
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/nkang--fix-confirmer-init |
sliptype
approved these changes
May 9, 2022
| @@ -71,8 +72,10 @@ function* watchUpdatePlaylistLibrary() { | |||
| yield takeEvery(update.type, function* updatePlaylistLibrary( | |||
| action: ReturnType<typeof update> | |||
| ) { | |||
Contributor
There was a problem hiding this comment.
Should we keep these logs?
Collaborator
|
Preview this change https://demo.audius.co/nkang--fix-confirmer-init |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Before:
There was a pending USER transaction on every app session load if the user had any playlist folders. This was because we compute playlists that are in the user's account but missing in their library - and if there are any, we update the playlist library. If the user had a folder with at least one playlist, the missing playlists were computed incorrectly - which caused the
update profileoperation to be called on every load.Dragons
Is there anything the reviewer should be on the lookout for? Are there any dangerous changes?
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.
How will this change be monitored?
For features that are critical or could fail silently please describe the monitoring/alerting being added.