This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[PAY-158] Add TipSentNotification#1288
Merged
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/dj-pay-158-tip-sent-notification |
rickyrombo
approved these changes
May 6, 2022
| <ProfilePicture className={styles.profilePicture} user={user} /> | ||
| <span> | ||
| {messages.sent} <AudioText value={value} /> {messages.to}{' '} | ||
| <UserNameLink user={user} notification={notification} addMargin /> |
Contributor
There was a problem hiding this comment.
Not a big fan of addMargin - it also looks like it's not necessary anymore. Now that the ArtistPopover is a span, it should keep the whitespace?
Think maybe we can remove this?
Contributor
Author
There was a problem hiding this comment.
yes down for sure, ahh that is why the whitespace was messed up, will do
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds TipSentNotification
