This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-457 C-461] Improve search-results collection/track screen load#1285
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/dj-c-457-improve-search-results-loading |
sliptype
approved these changes
May 5, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
Good stuff! This was bothering me a lot
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drastically improves perceived load time of tracks/collections screen from search-results page.
Dragons
It is a bit hacky adding SearchPlaylist/SearchTrack as acceptable types for each screen