This repository was archived by the owner on Oct 4, 2023. It is now read-only.
[C-363] Remove antd progress component and use stems ProgressBar component#1282
Merged
Conversation
Collaborator
|
Preview this change https://demo.audius.co/kj-Remove-antd-progress-component |
sliptype
approved these changes
May 3, 2022
sliptype
left a comment
Contributor
There was a problem hiding this comment.
I guess we are losing the error state here but that's probably fine
Contributor
Author
Yea, for now. It should still have copy letting the user know that an error happened and we can update the ProgressBar component in stems to handle more states if need be |
… ProgressBar component instead
64c0920 to
c09a44e
Compare
Member
|
Wait, why are we removing the error state? did we check in w/ julian? we should avoid changing UI with this migration |
Collaborator
|
Preview this change https://demo.audius.co/kj-Remove-antd-progress-component |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
[C-363]
Dragons
Does not have the active flashing animation, but can be added if the stems component is updated
How Has This Been Tested?
Manually tested
How will this change be monitored?
N/A