[PAY-166] Redesign Repost Notification#1276
Conversation
|
Preview this change https://demo.audius.co/dj-pay-166-redesign-repost-notification |
There was a problem hiding this comment.
Might make things easier to review if you make the base of this PR the branch for the other PR - then if the other one goes first you can rebase on main and set this PR back to main
EDIT: JK I see there's only two commits, looking at the second commit now 😄
|
Thank you for solving one of my problems for a while now, will do |
rickyrombo
left a comment
There was a problem hiding this comment.
Image preview of a repost notification 👀?
|
|
||
| import styles from './EntityLink.module.css' | ||
|
|
||
| type EntityType = (Collection | Track) & { user: User } |
There was a problem hiding this comment.
I have a feeling this may need to support Tips and Users in the future 😄
There was a problem hiding this comment.
yeah that's the hope :D
| } | ||
|
|
||
| export const getEntityLink = ( | ||
| entity: (Track & { user: User }) | (Collection & { user: User }), |
There was a problem hiding this comment.
Feels like we should break NotificationEntity into its own type
There was a problem hiding this comment.
yeah should be reusing EntityType, good callout
|
Preview this change https://demo.audius.co/dj-pay-166-redesign-repost-notification |
Description
Redesigns Repost Notification
EntityLinkcomponentTwitterShareButton