Add tipping audio to artists#1255
Conversation
|
Preview this change https://demo.audius.co/sd-tip-audio |
|
Preview this change https://demo.audius.co/sd-tip-audio |
1 similar comment
|
Preview this change https://demo.audius.co/sd-tip-audio |
|
Preview this change https://demo.audius.co/sd-tip-audio |
|
Preview this change https://demo.audius.co/sd-tip-audio |
|
Preview this change https://demo.audius.co/sd-tip-audio |
jowlee
left a comment
There was a problem hiding this comment.
Only looked at the store tipping saga - LGTM
piazzatron
left a comment
There was a problem hiding this comment.
This is epic!! Just a few little things I noticed when testing:
- Tip button doesn't have a hover state
- In the modal transition container, the back transition is super quick. Forward could use a bit more easing as well
- At least in firefox, the 'available to send' text and badge aren't vertically aligned
Review comment are mostly nits and stylistic things. Looks great.
|
Preview this change https://demo.audius.co/sd-tip-audio |
Fix become top supporter logic
|
Preview this change https://demo.audius.co/sd-tip-audio |
|
Preview this change https://demo.audius.co/sd-tip-audio |
|
Preview this change https://demo.audius.co/sd-tip-audio |
Description
Add button and functionality to tip audio to users.
Dragons
N/A
How Has This Been Tested?
Locally against staging.
Went through entire flow, tipped audio to different users, check solscan.io to make sure transactions did go through and that balances were updated.
How will this change be monitored?
Add metrics for tipping request/success/failure/twitter-share