Skip to content

Fix composer position for comments#9937

Merged
sliptype merged 3 commits into
mainfrom
sk-fix-composer-position
Oct 2, 2024
Merged

Fix composer position for comments#9937
sliptype merged 3 commits into
mainfrom
sk-fix-composer-position

Conversation

@sliptype

@sliptype sliptype commented Oct 2, 2024

Copy link
Copy Markdown
Contributor

Description

  • ComposerInput was misaligned in comments because of the offset being applied for DMs. Move the offset into ChatTextInput to make it specific to DMs

image

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

@changeset-bot

changeset-bot Bot commented Oct 2, 2024

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: c59919d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sliptype sliptype requested a review from a team October 2, 2024 20:14
@gitguardian

gitguardian Bot commented Oct 2, 2024

Copy link
Copy Markdown

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11648676 Triggered Generic High Entropy Secret c59919d core/infra/dev_config/sandbox-one.env View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@sliptype sliptype enabled auto-merge (squash) October 2, 2024 20:31
@sliptype sliptype merged commit 65762e8 into main Oct 2, 2024
@sliptype sliptype deleted the sk-fix-composer-position branch October 2, 2024 20:36
schottra added a commit that referenced this pull request Oct 3, 2024
…ient-v1-feed

* origin/main:
  Fix CAA tests (#9929)
  [C-5072] Comment timestamp seeking (#9935)
  [PAY-3488] Blast websockets respect permissions (#9932)
  [PAY-3489] Update web ComposerInput autocomplete range tracking (#9939)
  Honor existing chat (#9934)
  Audius Protocol v0.7.4
  [WIP] ::  [DOCS] Developer intro page work (#9931)
  [PAY-3453] Fix @ mentions in Dms with UserGeneratedTextV2 (#9924)
  Version Packages (#9914)
  [QA-875] Fix short feed on web sign in (#9943)
  Fix composer position for comments (#9937)
  [C-4998] Add timestamp highlighting to mobile composer input (#9930)
  Tag mri plugin container in discprov release (#9936)
  console with em and some reactivity (#9933)
audius-infra pushed a commit that referenced this pull request Oct 5, 2024
[efdc0b2] Fix bottom sheet keyboard avoiding + compose ui (#9964) Sebastian Klingler
[235406d] [C-5097] Add backspace handling back to mobile ComposerInput (#9962) Kyle Shanks
[2e3a4db] [C-4994] Add user autocomplete and tagging to mobile ComposerInput (#9952) Kyle Shanks
[160df4e] [QA-1748] Fix misc sign up issues (#9957) Raymond Jacobson
[5969168] [PAY-3493] Fix download gating on usdc feature flag (#9945) Raymond Jacobson
[f96333a] [C-5025] Add compose ui helper text (#9955) Sebastian Klingler
[d8db7ab] [C-5082] Comments desktop replies tweaks (#9954) JD Francis
[5bdf8ce] [C-5068] Convert comments a-query to tanstack-query (#9944) JD Francis
[17fb40e] Revert "[C-4493] Don't show deleted track rows in collections (#9209)" (#9951) Raymond Jacobson
[1ab28c9] [C-5071] Scroll to top for new comments on mobile (#9947) Sebastian Klingler
[2f2f187] [C-5072] Comment timestamp seeking (#9935) Sebastian Klingler
[0ba81b4] [PAY-3489] Update web ComposerInput autocomplete range tracking (#9939) Kyle Shanks
[e569aac] [PAY-3453] Fix @ mentions in Dms with UserGeneratedTextV2 (#9924) Raymond Jacobson
[e6ad563] Version Packages (#9914) github-actions[bot]
[143c9d4] [QA-875] Fix short feed on web sign in (#9943) Isaac Solo
[65762e8] Fix composer position for comments (#9937) Sebastian Klingler
[a73cd6e] [C-4998] Add timestamp highlighting to mobile composer input (#9930) Kyle Shanks
[b408810] [QA-1749] Fix help alignment (#9923) Raymond Jacobson
[ea69846] [PAY-3199] Inbox Settings UI (mobile) (#9922) Andrew Mendelsohn
[4851999] [C-5002] Empty comments state for track owner (#9928) Sebastian Klingler
[371c9fd] [C-5057] Make comment overflow actions consistent with designs (#9920) Sebastian Klingler
[4d646d6] [PAY-3477] Initialize Hedgehog directly in client (#9909) Randy Schott
[57666cb] Move debug to externals (#9917) Randy Schott
[ce35265] Upgrade mobile apps to 116 (#9927) Dylan Jeffers
[0a2fe3d] Notify Slack on new purchases (#9921) Marcus Pasell
[9d02b9f] [PAY-3329] Remove monetization beta waitlist (#9913) Raymond Jacobson
[220ed1d] [QA-1724] Fix broken insta links (#9911) Raymond Jacobson
[b8c3171] Unblock CI (#9915) Raymond Jacobson
[969fd1f] Migrate to new user/tracks/remixed endpoint (#9900) Andrew Mendelsohn
[7d2233d] [PAY-3455] Update unread element scroll function and fix chat page styling again (#9904) Kyle Shanks
[91f2e59] [QA-1522] Update web scrubber to track audio player directly (#9894) Randy Schott
[e69a986] [C-5022] Fix cached-image artwork and avatar (#9898) Dylan Jeffers
[5e764e6] [C-5058] Close reply input on submit (#9897) Dylan Jeffers
[5bc9a19] [C-5028] Hide sort buttons with 1 or fewer comments (#9896) Dylan Jeffers
[d2c0a82] [C-5070] Add comment count to artist dashboard (#9895) Dylan Jeffers
[3d84ce1] Version Packages (#9822) github-actions[bot]
[0c3f791] [PAY-3439] Add hono to create-audius-app (#9840) Raymond Jacobson
[1260471] [QA-1750] Fix race cond in cc flow with token account creation (#9902) Raymond Jacobson
[9694ea4] Fixes zodError when purchasing album with Coinflow (#9903) Marcus Pasell
[a7cc761] E2E muting users from comments (#9844) Isaac Solo
[981d8f9] fix sdk remixed tracks usage (#9901) Andrew Mendelsohn
[dd52ab0] Fix comment optimistic writes (#9876) JD Francis
[8f4314f] [PAY-3198] New inbox settings modal layout (#9893) Andrew Mendelsohn
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
samgutentag pushed a commit that referenced this pull request Nov 1, 2024
[efdc0b2] Fix bottom sheet keyboard avoiding + compose ui (#9964) Sebastian Klingler
[235406d] [C-5097] Add backspace handling back to mobile ComposerInput (#9962) Kyle Shanks
[2e3a4db] [C-4994] Add user autocomplete and tagging to mobile ComposerInput (#9952) Kyle Shanks
[160df4e] [QA-1748] Fix misc sign up issues (#9957) Raymond Jacobson
[5969168] [PAY-3493] Fix download gating on usdc feature flag (#9945) Raymond Jacobson
[f96333a] [C-5025] Add compose ui helper text (#9955) Sebastian Klingler
[d8db7ab] [C-5082] Comments desktop replies tweaks (#9954) JD Francis
[5bdf8ce] [C-5068] Convert comments a-query to tanstack-query (#9944) JD Francis
[17fb40e] Revert "[C-4493] Don't show deleted track rows in collections (#9209)" (#9951) Raymond Jacobson
[1ab28c9] [C-5071] Scroll to top for new comments on mobile (#9947) Sebastian Klingler
[2f2f187] [C-5072] Comment timestamp seeking (#9935) Sebastian Klingler
[0ba81b4] [PAY-3489] Update web ComposerInput autocomplete range tracking (#9939) Kyle Shanks
[e569aac] [PAY-3453] Fix @ mentions in Dms with UserGeneratedTextV2 (#9924) Raymond Jacobson
[e6ad563] Version Packages (#9914) github-actions[bot]
[143c9d4] [QA-875] Fix short feed on web sign in (#9943) Isaac Solo
[65762e8] Fix composer position for comments (#9937) Sebastian Klingler
[a73cd6e] [C-4998] Add timestamp highlighting to mobile composer input (#9930) Kyle Shanks
[b408810] [QA-1749] Fix help alignment (#9923) Raymond Jacobson
[ea69846] [PAY-3199] Inbox Settings UI (mobile) (#9922) Andrew Mendelsohn
[4851999] [C-5002] Empty comments state for track owner (#9928) Sebastian Klingler
[371c9fd] [C-5057] Make comment overflow actions consistent with designs (#9920) Sebastian Klingler
[4d646d6] [PAY-3477] Initialize Hedgehog directly in client (#9909) Randy Schott
[57666cb] Move debug to externals (#9917) Randy Schott
[ce35265] Upgrade mobile apps to 116 (#9927) Dylan Jeffers
[0a2fe3d] Notify Slack on new purchases (#9921) Marcus Pasell
[9d02b9f] [PAY-3329] Remove monetization beta waitlist (#9913) Raymond Jacobson
[220ed1d] [QA-1724] Fix broken insta links (#9911) Raymond Jacobson
[b8c3171] Unblock CI (#9915) Raymond Jacobson
[969fd1f] Migrate to new user/tracks/remixed endpoint (#9900) Andrew Mendelsohn
[7d2233d] [PAY-3455] Update unread element scroll function and fix chat page styling again (#9904) Kyle Shanks
[91f2e59] [QA-1522] Update web scrubber to track audio player directly (#9894) Randy Schott
[e69a986] [C-5022] Fix cached-image artwork and avatar (#9898) Dylan Jeffers
[5e764e6] [C-5058] Close reply input on submit (#9897) Dylan Jeffers
[5bc9a19] [C-5028] Hide sort buttons with 1 or fewer comments (#9896) Dylan Jeffers
[d2c0a82] [C-5070] Add comment count to artist dashboard (#9895) Dylan Jeffers
[3d84ce1] Version Packages (#9822) github-actions[bot]
[0c3f791] [PAY-3439] Add hono to create-audius-app (#9840) Raymond Jacobson
[1260471] [QA-1750] Fix race cond in cc flow with token account creation (#9902) Raymond Jacobson
[9694ea4] Fixes zodError when purchasing album with Coinflow (#9903) Marcus Pasell
[a7cc761] E2E muting users from comments (#9844) Isaac Solo
[981d8f9] fix sdk remixed tracks usage (#9901) Andrew Mendelsohn
[dd52ab0] Fix comment optimistic writes (#9876) JD Francis
[8f4314f] [PAY-3198] New inbox settings modal layout (#9893) Andrew Mendelsohn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants