Skip to content

[PAY-3457] Fix chat blast triggering chatlist resort #9864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dharit-tan merged 3 commits into from
Sep 25, 2024
Merged

[PAY-3457] Fix chat blast triggering chatlist resort #9864

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92ed334
[PAY-3457] Fix chat blast triggering chatlist resort
dharit-tan Sep 25, 2024
62bbc2b
comment
dharit-tan Sep 25, 2024
f56995e
readable
dharit-tan Sep 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 18 additions & 8 deletions packages/common/src/store/pages/chat/slice.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -485,17 +485,28 @@ const slice = createSlice({
return
}

// Update the chat metadata, but don't update recheck_permissions unless
// it's a message received from someone else
// Always update the last message, but don't update
// last_message_at if it's a blast message sent by current user,
// to avoid chat list re-sorting.
// Note: is_plaintext indicates that the message originated from a blast
const existingChat = getChat(state, chatId)
const changes =
message.is_plaintext && isSelfMessage && !existingChat?.is_blast
? {
last_message: message.message
}
: {
last_message: message.message,
last_message_at: message.created_at
}

chatsAdapter.updateOne(state.chats, {
id: chatId,
changes: {
last_message: message.message,
last_message_at: message.created_at
}
changes
})

// Return early if we've seen this message
// Return early if we've seen this message: don't update
// recheck_permissions unless it's a message received from someone else
const existingMessage = getMessage(
state.messages[chatId],
message.message_id
Expand All @@ -520,7 +531,6 @@ const slice = createSlice({
recalculatePreviousMessageHasTail(state.messages[chatId], 0)

// Handle unread counts
const existingChat = getChat(state, chatId)
if (!existingChat || existingChat.is_blast) return
const optimisticRead = state.optimisticChatRead[chatId]
const existingUnreadCount = optimisticRead
Expand Down