Skip to content

[PAY-3386] Implement mobile pay with anything#9674

Merged
raymondjacobson merged 2 commits into
mainfrom
rj-pay-3386
Sep 9, 2024
Merged

[PAY-3386] Implement mobile pay with anything#9674
raymondjacobson merged 2 commits into
mainfrom
rj-pay-3386

Conversation

@raymondjacobson

@raymondjacobson raymondjacobson commented Sep 7, 2024

Copy link
Copy Markdown
Member

Description

This really needs a refactor, but it does work! Hopefully we can do that next week :-)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide repro instructions & any configuration.

Purchased track w/ $AUDIO via phantom on stage

@changeset-bot

changeset-bot Bot commented Sep 7, 2024 •
edited
Loading

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 1c2b45e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

raymondjacobson
raymondjacobson commented Sep 7, 2024
View reviewed changes
Comment thread packages/common/src/store/purchase-content/sagas.ts
contentType: PurchaseableContentType
}

const serializeKeyPair = (value: BoxKeyPair) => {

@raymondjacobson raymondjacobson Sep 7, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this code is avail in mobile, put it into common util

raymondjacobson
raymondjacobson commented Sep 7, 2024
View reviewed changes
Comment thread packages/common/src/store/purchase-content/sagas.ts
const mobileWalletActions = yield* getContext('mobileWalletActions')
if (isNativeMobile && mobileWalletActions) {
const { connect } = mobileWalletActions
const getWalletConnectPublicKey = (state: any) =>

@raymondjacobson raymondjacobson Sep 7, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the first gross thing -- common needs to reach into mobile store here. ew.

raymondjacobson
raymondjacobson commented Sep 7, 2024
View reviewed changes
Comment thread packages/mobile/src/screens/wallet-connect/usePhantomConnect.ts
const dispatch = useDispatch()
const { params } = useRoute<WalletConnectRoute<'Wallets'>>()
const route = useRoute<WalletConnectRoute<'Wallets'>>()
// I have no idea what's going on here. I don't think this works currently,

@raymondjacobson raymondjacobson Sep 7, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fr no cap what is happening??? this change makes it work... maybe a local dev thing?

raymondjacobson
raymondjacobson commented Sep 7, 2024
View reviewed changes
Comment thread packages/mobile/src/screens/wallet-connect/usePhantomConnect.ts

// The following set of cases are hooks that handle deep links from
// Phantom back to Audius.
if (params.path === 'connect') {

@raymondjacobson raymondjacobson Sep 7, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't like the name

raymondjacobson
raymondjacobson commented Sep 7, 2024
View reviewed changes
Comment thread packages/common/src/store/purchase-content/sagas.ts
const { connect } = mobileWalletActions
const getWalletConnectPublicKey = (state: any) =>
state.walletConnect.publicKey
const dappKeyPair = nacl.box.keyPair()

@raymondjacobson raymondjacobson Sep 7, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should create this and persist it via redux-persist, so you only have to "connect" once

@raymondjacobson raymondjacobson Sep 7, 2024

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this can be a follow up

@audius-infra

audius-infra commented Sep 7, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rj-pay-3386

@audius-infra

audius-infra commented Sep 7, 2024

Copy link
Copy Markdown
Collaborator

Preview this change https://demo.audius.co/rj-pay-3386

dylanjeffers
dylanjeffers approved these changes Sep 9, 2024
View reviewed changes

@dylanjeffers dylanjeffers left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

epic

@raymondjacobson raymondjacobson merged commit 909e63e into main Sep 9, 2024
@raymondjacobson raymondjacobson deleted the rj-pay-3386 branch September 9, 2024 16:59
audius-infra pushed a commit that referenced this pull request Sep 14, 2024
Audius Client (Web and Mobile) v1.5.99
b72a097 
[0146829] [QA-1646] Fix saga for watching uploaded tracks and refreshing profile (#9742) Randy Schott
[e22656f] [QA-1723] Fix filter options button helper text (#9752) Raymond Jacobson
[b661bcf] Revert "App Delight POC (#9749)" (#9751) Reed
[9ee8c8b] Bump mobile app to 114 (#9750) Dylan Jeffers
[a0c8772] App Delight POC (#9749) Reed
[1d26efc] Bump android build number (#9748) Raymond Jacobson
[b20db11] Fix null query in search (#9747) Sebastian Klingler
[d83f750] [C-4942] Add un-authed popup to web comments (#9681) JD Francis
[2557e04] [QA-1340] Fix page header grossness (#9741) Kyle Shanks
[4ed8fdc] [QA-1596] Fix timestamp for adding track to playlist (#9717) Isaac Solo
[15e68ee] [QA-1462] Fix delete account button spacing (#9721) JD Francis
[aab4663] [QA-954] Add payments route to auth routes (#9735) Kyle Shanks
[2ad9ba9] [QA-1125] Remove add to playlist disabled option logic (#9723) Kyle Shanks
[eaa3d5b] [QA-1487] Fix camera icon in avatar (#9729) Reed
[cd725ff] [QA-1610] Fix mobile collection edit validatation (#9738) Dylan Jeffers
[f8fe56a] [QA-1652] Add loading state to connected wallets (#9727) Raymond Jacobson
[8158a83] [QA-1553] Remove extra space below mobile profile socials (#9716) Sebastian Klingler
[efcd387] [QA-1472] Fix GiantTrackTile spacing (#9734) Andrew Mendelsohn
[8d143a3] [QA-1134] Fix styles for date picker on scheduled release modal (#9708) Danny
[18b44d7] [QA-1692] Fix inconsistent font weight in upload text (#9694) Danny
[7aa299e] [QA-1516] Hide share button on hidden milestones (#9731) Dylan Jeffers
[f8eb5e1] [QA-1350] Remove links for deleted tracks in tracks table (#9713) Randy Schott
[cd4bb07] [QA-1716] Fix removing songs from playlists (#9728) Marcus Pasell
[5536442] Stop music on signout (#9726) Sebastian Klingler
[65413ff] [QA-1483] Remove artist-pick in feed (#9718) Dylan Jeffers
[fb4f6ff] [QA-1588] Update reload anyway button styling (#9712) Kyle Shanks
[252c703] [QA-291] Fix explore page perspective card sensitivity (#9725) Dylan Jeffers
[d4d6ac3] Fix follow card lint (#9720) alecsavvy
[5cb7cae] [QA-1714] Fix mobile web track-page loading (#9715) Dylan Jeffers
[24d0467] QA-1028: disable artist preview on signup for users with no tracks (#9707) alecsavvy
[1ff386f] [QA-1502] Fix Add Funds modal hint spacing (#9710) Kyle Shanks
[526e918] [QA-1548] Fix create playlist (#9709) Sebastian Klingler
[efea3a9] [QA-874] Fix shadow spacing on mobile profile artist badge (#9706) Andrew Mendelsohn
[9ecd56e] [QA-1564] Redirect to feed if user is already authed (#9693) JD Francis
[214f409] [QA-808] Clip long artist names on mobile signup (#9702) Reed
[26c07f4] QA-1715 Fix horizontal scrollbar in scheduled release (#9705) Marcus Pasell
[2517fb0] [QA-1107] Fix TrackTile title lengths for podcasts (#9703) Kyle Shanks
[970392e] [QA-1143] Update settings page download section (#9697) Kyle Shanks
[e96b92e] [QA-1552] Fix incorrect settings card order on web (#9687) Randy Schott
[056dffc] QA-1378: fix withdrawal history extra grey space (#9699) alecsavvy
[10fbc63] [QA-1586] Rewards Page: 1px boder, 1px divider (#9696) Marcus Pasell
[8ec9ee2] [QA-1563] Close locked content drawer on CTA click (#9692) Reed
[e60b91b] [QA-1410] [QA-1492] Socials icons padding (#9695) Sebastian Klingler
[98e9700] [QA-990] Persist mobile theme on sign-out (#9701) Dylan Jeffers
[5c0bf13] [qa-1255] Fix bg color on premium giant track tiles (#9689) Sebastian Klingler
[929c1de] [QA-1587] Fix empty Jupiter quote on page load (#9690) Marcus Pasell
[f12916d] [QA-1712] Fix trending header (#9698) Dylan Jeffers
[99faad7] [QA-1711] Fix remix field not editable (#9685) Dylan Jeffers
[70c3fa1] Fix pay with anything (#9684) Raymond Jacobson
[ee7bb3f] [C-4954] mobile comments pagination (#9659) Sebastian Klingler
[e0d3154] [C-4966|C-4967] E2E working comment reactions (#9670) JD Francis
[909e63e] [PAY-3386] Implement mobile pay with anything (#9674) Raymond Jacobson
[b49fa9b] [C-5010] Add comment reply counts (#9664) Dylan Jeffers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffers dylanjeffers dylanjeffers approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson @audius-infra @dylanjeffers