-
Notifications
You must be signed in to change notification settings - Fork 131
[PAY-3372] Add sales aggregate endpoint #9585
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
packages/discovery-provider/src/queries/get_sales_aggregate.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| from typing import Optional, TypedDict | ||
|
|
||
| from sqlalchemy import func | ||
|
|
||
| from src.models.users.usdc_purchase import USDCPurchase | ||
| from src.queries.query_helpers import add_query_pagination | ||
| from src.utils.db_session import get_db_read_replica | ||
|
|
||
|
|
||
| class GetSalesAggregateArgs(TypedDict): | ||
| seller_user_id: Optional[int] | ||
| limit: int | ||
| offset: int | ||
|
|
||
|
|
||
| def _get_sales_aggregate(session, args: GetSalesAggregateArgs): | ||
| query = ( | ||
| session.query( | ||
| USDCPurchase.content_id, | ||
| USDCPurchase.content_type, | ||
| func.count(USDCPurchase.buyer_user_id).label("purchase_count"), | ||
| ) | ||
| .filter(USDCPurchase.seller_user_id == args.get("seller_user_id")) | ||
| .group_by(USDCPurchase.content_id, USDCPurchase.content_type) | ||
| ) | ||
|
|
||
| return query | ||
|
|
||
|
|
||
| def get_sales_aggregate(args: GetSalesAggregateArgs): | ||
| """Aggregates USDCPurchase count by content_id and content_type for a given seller_user_id.""" | ||
| db = get_db_read_replica() | ||
| with db.scoped_session() as session: | ||
| query = _get_sales_aggregate(session, args) | ||
| limit = args.get("limit") | ||
| offset = args.get("offset") | ||
|
|
||
| results = add_query_pagination(query, limit, offset).all() | ||
| sales_aggregate_list = [row._asdict() for row in results] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤯 why haven't we been using this instead of |
||
|
|
||
| return sales_aggregate_list | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
super nit: maybe order by purchase_count desc?