Skip to content

[QA-1446] Fix popup alignment #9389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
raymondjacobson merged 2 commits into from
Aug 7, 2024
Merged

[QA-1446] Fix popup alignment #9389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc467c3
[QA-1446] Fix popup alignment
raymondjacobson Aug 7, 2024
5b904fe
Update portal version
raymondjacobson Aug 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions packages/harmony/src/components/popup/Popup.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,17 +55,15 @@ const getComputedOrigins = (

let containerWidth, containerHeight
if (containerRef && containerRef.current) {
const containerRect = containerRef.current.getBoundingClientRect()
containerWidth =
containerRef.current.getBoundingClientRect().width -
CONTAINER_INSET_PADDING
containerRect.width + containerRect.x - CONTAINER_INSET_PADDING
containerHeight =
containerRef.current.getBoundingClientRect().height -
CONTAINER_INSET_PADDING
containerRect.height + containerRect.y - CONTAINER_INSET_PADDING
} else {
containerWidth =
portal.getBoundingClientRect().width - CONTAINER_INSET_PADDING
containerHeight =
portal.getBoundingClientRect().height - CONTAINER_INSET_PADDING
const portalRect = portal.getBoundingClientRect()
containerWidth = portalRect.width + portalRect.x - CONTAINER_INSET_PADDING
containerHeight = portalRect.height + portalRect.y - CONTAINER_INSET_PADDING
}

// Get new wrapper position
Expand Down
1 change: 1 addition & 0 deletions packages/web/src/components/menu/Menu.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@ const Menu = forwardRef<HTMLDivElement, MenuProps>((props, ref) => {
items={items}
onClose={onClose}
anchorOrigin={{ vertical: 'bottom', horizontal: 'right' }}
transformOrigin={{ vertical: 'top', horizontal: 'left' }}
ref={ref}
renderTrigger={children}
zIndex={zIndex}
Expand Down