Skip to content

[QA-1452] Fix edit playlist issues #9226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanjeffers merged 1 commit into from
Jul 22, 2024
Merged

[QA-1452] Fix edit playlist issues #9226

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/libs/src/services/schemaValidator/schemas/playlistSchema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,13 +64,7 @@
"default": null
}
},
"required": [
"playlist_name",
"playlist_id",
"description",
"is_album",
"is_private"
Comment on lines -71 to -72

@amendelsohn amendelsohn Jul 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I think this is functionally fine? We probably set default values on discovery if these aren't provided.

However, I do see an argument for leaving them as most clients really ought to know their desired values, and it prevents mistakenly using those defaults when we shouldn't.

@dylanjeffers dylanjeffers Jul 22, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do they need to be required though? fwiw sdk only puts "playlist_name" as required

@amendelsohn amendelsohn Jul 22, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah probably not. Depends if we're trying to save devs from themselves or not 🤷

],
"required": ["playlist_name", "playlist_id"],
"title": "Playlist"
},
"CID": {
Expand Down