[C-4668] Improve web search v2 perf and structure by sliptype · Pull Request #9134 · AudiusProject/apps

sliptype · 2024-07-15T22:49:19Z

Description

Refactor web search v2 to only request relevant category
Refactor to use audius-query
Fix purchasable tracks not showing up in mobile results
Show all category for paths matching /search?query=xyz instead of /search/all?query=xyz

NOTE: still need to fix some loading states

How Has This Been Tested?

Tested locally, web and mobile

changeset-bot · 2024-07-15T22:49:23Z

⚠️ No Changeset found

Latest commit: 75bf56a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

sliptype · 2024-07-16T15:50:24Z

-        select(getSearchResultsPageTracks)
-      ])
-      const sortedTracks = (sortedIds as number[]).map((id) => tracks[id])
+      const tracks = yield* select(getTracks, { ids: trackIds })


Please double check my thinking here. The previous logic made no sense to me because we select trackIds and then select it again in the all call

yea I think you're right, this is one less fetch

Kyle-Shanks · 2024-07-16T20:31:16Z

+// NOTE: This is different from SearchCategory because
+// it uses `profiles` instead of `users`


Kyle-Shanks

BIG

[0c89479] [PAY-3174][PAY-3179] Do not show confirmation modals for edit access during upload (#9204) Saliou Diallo [a88b39b] [C-4493] Don't show deleted track rows in collections (#9209) Andrew Mendelsohn [8712eb8] [C-4831] Populate AudiusQueryContext in fetchSaga (#9203) Andrew Mendelsohn [69d6c0c] [C-4851] Update artwork and metadata fields layout (#9207) Andrew Mendelsohn [e77abfb] Improve loading and debounce logic for advanced search tracks (#9206) Sebastian Klingler [39ad581] [C-4849] Fullwidth AI attribution dropdown (#9205) Andrew Mendelsohn [05db4bc] [PAY-3181][PAY-3182] Remove hidden tracks from trending (#9202) Saliou Diallo [f034349] [QA-1461] Fix search v1 tag search (#9201) Dylan Jeffers [237aa88] [C-4698] Route to solana play store in rate-cta-drawer (#9198) Dylan Jeffers [65aca0b] [C-4698] Add solana dapp store update link (#9197) Dylan Jeffers [78f501e] [C-4813 C-4814] Update release date and scheduled release (#9188) Dylan Jeffers [790a30f] [PAY-3183] Fix mobile track header and special access box (#9187) Raymond Jacobson [48ba3a0] [C-4804] Improve search performance pt 2 (#9185) Sebastian Klingler [d5e5f83] [QA-1457] Fix purchase tab (#9191) Dylan Jeffers [4bff092] Undo web filter button sorting (#9190) Kyle Shanks [e07093e] [QA-1456] Hide purchase button and stats on tombstoned track rows (#9183) Andrew Mendelsohn [b60693d] [C-4797] Fix BPM screen scroll clipping (#9180) Kyle Shanks [e1b107a] [C-4740] Update loading state for new search screen track results (#9176) Kyle Shanks [2534f81] [QA-1453] Big user-list images (#9182) Dylan Jeffers [c6e607c] [C-4677] Include albums and playlists in tag search (#9179) Sebastian Klingler [41c6011] [C-4692] Fix filter button option active help text color (#9181) Kyle Shanks [86638a5] [PAY-3173] Update native mobile library for locked and hidden tracks (#9177) Saliou Diallo [28cfba5] [QA-1451] Fix track tile action buttons (#9178) Dylan Jeffers [9e542c2] [C-4744] Change clear recent search button to plain button (#9175) Kyle Shanks [ca05312] [PAY-3163] Update editable access in native mobile (#9174) Saliou Diallo [dba2775] Remove description dupe (#9173) Saliou Diallo [a106da4] [C-4810, C-4801, C-4790, PAY-3171] Fix publish album tracks behavior; update confirmation modals (#9172) Andrew Mendelsohn [418ecf2] [C-4803] Add mobile Price and Audience Field (#9168) Dylan Jeffers [d236600] Fix mobile upload bpm requirement (#9171) Dylan Jeffers [6a13fa3] [C-4675] [C-4665] [C-4736] [C-4732] [C-4737] [C-4734] [C-4742] Advanced search UI qa fixes part 2 (#9170) Sebastian Klingler [3ec2e15] [C-4757] Add simple sorting for filter buttons with values (#9165) Kyle Shanks [f861a9a] [C-4672] [C-4745] [C-4807] Advanced search UI qa fixes (#9167) Sebastian Klingler [8d18c27] [C-4788] Update filter button to fix toggle filter button functionality (#9164) Kyle Shanks [2f19663] [C-4805] Fix track filters (#9159) Sebastian Klingler [2a2aeeb] Fix usage of missing SDK function for Manager Mode reject flow (#9163) Randy Schott [b07590c] [C-4671] Add clear search button (#9162) Sebastian Klingler [ff4c649] [C-4789] Update web key and bpm filter buttons to respect the filter value (#9161) Kyle Shanks [79f0e5e] [PAY-3168] Remove SDK shadowing (#9157) Randy Schott [818c73b] [C-4787] Fix advanced search sort dropdowns (#9158) Sebastian Klingler [45c93fb] [PAY-3148] Add better support for gated tracks in library (#9156) Saliou Diallo [86d9b7a] Add UTM tracking in amplitude (#9153) Isaac Solo [ffd2ad3] [PAY-2783] Add filters to manager endpoints (#9109) Randy Schott [dc387b0] [PAY-3166] Updates ESLint dependencies to fix broken IDE experience (#9146) Randy Schott [d68b57e] [C-4796] Mobile Visibility Field (#9152) Dylan Jeffers [6c9e2b5] Fix type error (#9151) Sebastian Klingler [7246503] [QA-1429] Fix avatar sizing (#9154) Dylan Jeffers [28de67e] [QA-1443] Remove faulty download all logic (#9149) Raymond Jacobson [139bb9c] [C-4794] Hide social actions on now playing drawer for hidden tracks (#9150) Reed [02b75bb] [C-4668] Improve web search v2 perf and structure (#9134) Sebastian Klingler [3d5ff3a] [C-4777] Prevent public track with future release date (#9139) Reed [12becab] [C-4719] Fix local collections selector (#9145) Andrew Mendelsohn [4be6e57] [PAY-3164] Allow editing access for download-only gated tracks (#9143) Saliou Diallo [c07106d] [C-4772] Update mobile filter buttons to respect filter value (#9142) Kyle Shanks [7794808] [QA-964] Fix too many suggested artists (#9138) Raymond Jacobson [b97c0fc] Fix offline mode after fast load change (#9137) Raymond Jacobson [83020e0] [C-4709] Fix modals on mobile-web (#9136) Reed [4a635ca] [C-4778, C-4786] Update visibility change confirmation (#9135) Andrew Mendelsohn [46074ae] Fix account playlists entering cache and caching of currentWeb3User (#9131) Raymond Jacobson [97ae887] Filter out searchv2 history items for search v1 (#9127) Sebastian Klingler [1d64f8c] [C-4776] Fix edit collection submit (#9126) Dylan Jeffers [ec16b61] [C-4771] Hide stats in TracksTable for hidden tracks (#9125) Reed [0f62cc0] Fix slow startup (#9121) Raymond Jacobson [3f04084] Bump mobile apps to 107 (#9124) Dylan Jeffers [3c055df] [PAY-3149] Edit track confirmation modal when listeners may lose access (#9107) Saliou Diallo [b3a6b89] Fix web lint and permalink passing (#9122) Raymond Jacobson [aa64792] Fix misc component issues on startup (#9118) Raymond Jacobson

sliptype added 10 commits July 11, 2024 10:21

Include includePurchaseable on mobile

60aad1a

Include includePurchaseable on mobile pt 2

2e523dc

Merge branch 'main' into sk-c-4668-search-perf

fc905e0

Refactor TracksResults to use audius-query

2d84e16

Add track results to AllResults

315ae07

Refactor ProfileResults

c47e57d

Refactor AlbumResults

4ca2d21

Refactor PlaylistResults

cc4138f

Add headings

9810071

Clean up

8736d1c

sliptype requested review from Kyle-Shanks and dylanjeffers July 15, 2024 22:49

pull-request-size Bot added the size/XXL label Jul 15, 2024

Lint fixes

35cb6e5

sliptype commented Jul 16, 2024

View reviewed changes

Clean up

6661ec5

Kyle-Shanks reviewed Jul 16, 2024

View reviewed changes

Kyle-Shanks approved these changes Jul 16, 2024

View reviewed changes

sliptype added 4 commits July 16, 2024 16:48

Improve loading states

67a1b6e

Remove some duplicate requests

6d24c8f

Remove todo

607800d

Lint fixes

75bf56a

sliptype enabled auto-merge (squash) July 16, 2024 22:48

sliptype merged commit 02b75bb into main Jul 16, 2024

sliptype deleted the sk-c-4668-search-perf branch July 16, 2024 23:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[C-4668] Improve web search v2 perf and structure#9134

[C-4668] Improve web search v2 perf and structure#9134
sliptype merged 16 commits into
mainfrom
sk-c-4668-search-perf

sliptype commented Jul 15, 2024 •

edited

Loading

Uh oh!

changeset-bot Bot commented Jul 15, 2024 •

edited

Loading

Uh oh!

sliptype Jul 16, 2024 •

edited

Loading

Uh oh!

Kyle-Shanks Jul 16, 2024

Uh oh!

Kyle-Shanks Jul 16, 2024

Uh oh!

Kyle-Shanks left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		// NOTE: This is different from SearchCategory because
		// it uses `profiles` instead of `users`

Uh oh!

Conversation

sliptype commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

How Has This Been Tested?

Uh oh!

changeset-bot Bot commented Jul 15, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️ No Changeset found

Uh oh!

sliptype Jul 16, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Kyle-Shanks Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

Kyle-Shanks Jul 16, 2024

Choose a reason for hiding this comment

Uh oh!

Kyle-Shanks left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

sliptype commented Jul 15, 2024 •

edited

Loading

changeset-bot Bot commented Jul 15, 2024 •

edited

Loading

sliptype Jul 16, 2024 •

edited

Loading