Skip to content

Automate bundle install in postinstall script #6387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sliptype merged 1 commit into from
Oct 18, 2023
Merged

Automate bundle install in postinstall script #6387

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 0 additions & 10 deletions packages/mobile/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,16 +4,6 @@ The Audius React Native mobile client

## Setup

### Extra iOS Setup

```bash

@dylanjeffers dylanjeffers Oct 18, 2023

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a niceee improvement

gem install cocoapods

cd ios
pod install
cd ..
```

## Running iOS

```bash
Expand Down
1 change: 1 addition & 0 deletions scripts/postinstall.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ if [[ -z "${SKIP_POD_INSTALL}" ]]; then
cd packages/mobile/node_modules
ln -s ../../../node_modules/react-native react-native
cd ../ios
bundle check || bundle install
if command -v pod >/dev/null; then
pod install
fi
Expand Down