Skip to content

SDK: Update CI to allow version, preid to be specified #4750

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickyrombo merged 9 commits into from
Feb 10, 2023
Merged

SDK: Update CI to allow version, preid to be specified #4750

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7a14645
Fix script to allow version paramter, temporarily disable publish
rickyrombo Feb 10, 2023
b66a3bf
Change circle ci to publish sdk with a specified version
rickyrombo Feb 10, 2023
f0148e5
Update script to take preid if specified
rickyrombo Feb 10, 2023
ea9649c
Add params to sdk-release
rickyrombo Feb 10, 2023
5778b58
Temp disable main/release branch check
rickyrombo Feb 10, 2023
df61661
undo testing changes
rickyrombo Feb 10, 2023
b334c1f
Revert "undo testing changes"
rickyrombo Feb 10, 2023
bea524e
default to patch
rickyrombo Feb 10, 2023
67e8098
Reland "undo testing changes"
rickyrombo Feb 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 17 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,12 @@ parameters:
full_ci:
type: boolean
default: false
sdk_version:
type: string
default: "patch"
sdk_preid:
type: string
default: ""

jobs:
noop:
Expand Down Expand Up @@ -353,6 +359,14 @@ jobs:
description: The git commit to build and release
type: string
default: ""
version:
description: The version to publish
type: string
default: ""
preid:
description: See npm version preid
type: string
default: ""
slack_mentions_user:
description: Used for CircleCI @mentions
type: string
Expand Down Expand Up @@ -388,7 +402,7 @@ jobs:
name: Bump and Publish Libs
command: |
export PROTOCOL_DIR=/home/circleci/project
libs/scripts/release.sh << parameters.sdk_release_commit >>
libs/scripts/release.sh << parameters.sdk_release_commit >> << parameters.version >> << parameters.preid >>
- slack-fail:
branch_pattern: main
slack_mentions_user: << parameters.slack_mentions_user >>
Expand Down Expand Up @@ -1781,6 +1795,8 @@ workflows:
name: publish-sdk (<< pipeline.parameters.sdk_release_commit >>)
sdk_release_commit: << pipeline.parameters.sdk_release_commit >>
slack_mentions_user: << pipeline.parameters.slack_mentions_user >>
preid: << pipeline.parameters.sdk_preid >>
version: << pipeline.parameters.sdk_version >>
context:
- Audius Client
- slack-secrets
Expand Down
11 changes: 10 additions & 1 deletion libs/scripts/release.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,15 @@ else
GIT_COMMIT=${1}
fi

if [[ -z ${2} ]]; then
echo "A version must be supplied as the second parameter (See `npm version` for valid values)."
exit 2
else
RELEASE_VERSION=${2}
fi

PREID=${3}

if [[ $(whoami) != "circleci" ]]; then
echo "This script is intended to be run through CI."
echo "Please see:"
Expand Down Expand Up @@ -66,7 +75,7 @@ function git-reset () {
function bump-version () {
(
# Patch the version
VERSION=$(npm version patch)
VERSION=$(npm version ${RELEASE_VERSION} --preid=${PREID})
Comment thread
rickyrombo marked this conversation as resolved.
tmp=$(mktemp)
jq ". += {audius: {releaseSHA: \"${GIT_COMMIT}\"}}" package.json > "$tmp" \
&& mv "$tmp" package.json
Expand Down