Skip to content

Encode artist pick track id in API responses #4725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
michellebrier merged 3 commits into from
Feb 8, 2023
Merged

Encode artist pick track id in API responses #4725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2997bfd
encode artist pick in user response
michellebrier Feb 6, 2023
170a95b
Fix field type
michellebrier Feb 6, 2023
4b3c1f2
Accidentally checked
michellebrier Feb 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions discovery-provider/src/api/v1/helpers.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,9 @@ def extend_user(user, current_user_id=None):
return user
user_id = encode_int_id(user["user_id"])
user["id"] = user_id
if user.get("artist_pick_track_id"):
artist_pick_track_id = encode_int_id(user["artist_pick_track_id"])
user["artist_pick_track_id"] = artist_pick_track_id
user = add_user_artwork(user)
# Do not surface playlist library in user response unless we are
# that user specifically
Expand Down
2 changes: 1 addition & 1 deletion discovery-provider/src/api/v1/models/users.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"user",
{
"album_count": fields.Integer(required=True),
"artist_pick_track_id": fields.Integer(allow_null=True),
"artist_pick_track_id": fields.String(allow_null=True),
"bio": fields.String,
"cover_photo": fields.Nested(cover_photo, allow_null=True),
"followee_count": fields.Integer(required=True),
Expand Down