Skip to content

Set reconfig blacklist#3871

Merged
SidSethi merged 6 commits into
masterfrom
vg-blacklist-reconfig
Sep 18, 2022
Merged

Set reconfig blacklist#3871
SidSethi merged 6 commits into
masterfrom
vg-blacklist-reconfig

Conversation

@vicky-g

@vicky-g vicky-g commented Sep 14, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Adds a configurable blacklist for reconfig via an env var.

Tests

  • Manually added the array via config.js to see if in selection that explicitly passed in nodes do not get reconfigured
  • Test via setting env var in base.env

Monitoring - How will this change be monitored? Are there sufficient logs / alerts?

Look for the log [_selectRandomReplicaSetNodes] wallet= prefix

@vicky-g vicky-g marked this pull request as ready for review September 14, 2022 21:09
@vicky-g vicky-g requested a review from SidSethi September 14, 2022 21:09
@vicky-g

vicky-g commented Sep 14, 2022

Copy link
Copy Markdown
Contributor Author

not super sure as to why the sdk ci is failing

dmanjunath
dmanjunath reviewed Sep 16, 2022
View reviewed changes

@dmanjunath dmanjunath left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for adding this. just had a few suggestions

Comment thread creator-node/src/config.js
Comment thread ...r-node/src/services/stateMachineManager/stateReconciliation/updateReplicaSet.jobProcessor.ts Outdated
@pull-request-size pull-request-size Bot added size/M and removed size/S labels Sep 16, 2022
SidSethi
SidSethi reviewed Sep 16, 2022
View reviewed changes

@SidSethi SidSethi left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple small comments
also can merge master to get latest CI run

Comment thread creator-node/src/config.js Outdated
Comment thread creator-node/src/config.js
Comment thread ...r-node/src/services/stateMachineManager/stateReconciliation/updateReplicaSet.jobProcessor.ts Outdated
@vicky-g vicky-g requested a review from SidSethi September 16, 2022 22:07
@SidSethi SidSethi merged commit 9720cb9 into master Sep 18, 2022
@SidSethi SidSethi deleted the vg-blacklist-reconfig branch September 18, 2022 20:00
audius-infra pushed a commit that referenced this pull request Sep 27, 2022
Bump sdk to v1.0.6
00362be 
## Changelog

- 2022-09-27 [e85874b] [PAY-480][PAY-482][PAY-488][PAY-503][PAY-520][PAY-588] Activate premium content middleware (#3841) [Saliou Diallo]
- 2022-09-27 [d075c43] [PAY-631] Update filter logic for trending premium content (#3904) [Saliou Diallo]
- 2022-09-26 [13d48e5] Await CN services before starting server (#3937) [Theo Ilie]
- 2022-09-26 [56340ff] Run Content Node on multiple cluster processes and migrate Bull->BullMQ (#3881) [Theo Ilie]
- 2022-09-26 [a39471f] Add Hyperpop to trending (#3931) [Raymond Jacobson]
- 2022-09-23 [620ab53] INF-251 don't send Starting nor Success slack messages for auto-deploys (#3935) [Joaquin Casares]
- 2022-09-23 [36884df] Patch staging CN delegateOwnerWallet (#3933) [Sid Sethi]
- 2022-09-23 [d662e84] INF-251 Streamlined reorg for Deployment Pipeline (#3934) [Joaquin Casares]
- 2022-09-23 [f1e0981] INF-251 add host to post-health check logs (#3932) [Joaquin Casares]
- 2022-09-23 [40af9d4] Block notifs on error 7 (#3930) [Michael Piazza]
- 2022-09-23 [60b6310] INF-251 reorg production deployment flow w/release-day lessons (#3927) [Joaquin Casares]
- 2022-09-23 [37b651c] INF-251 always deploy to canaries first (#3924) [Joaquin Casares]
- 2022-09-23 [53e96f8] INF-251 remove hold job for auto-deploying to staging (#3926) [Joaquin Casares]
- 2022-09-23 [bc0fe57] Remove handle relay blocking logic (#3921) [Michael Piazza]
- 2022-09-23 [5cf8e3f] Add upload track to audius-cmd (#3915) [Cheran]
- 2022-09-23 [dc2ec68] CON-402 CN Remove all synchronous disk ops (#3908) [Sid Sethi]
- 2022-09-22 [e438b87] Add check for GCP DBs in check-secrets.sh (#3925) [Michael Piazza]
- 2022-09-22 [5dc84a9] Update stage contract addresses to goerli (#3922) [Isaac Solo]
- 2022-09-22 [df427a9] INF-251 don't block releases for test-eth-contracts (#3920) [Joaquin Casares]
- 2022-09-22 [1a134bb] INF-251 throttle prod releases (#3919) [Joaquin Casares]
- 2022-09-22 [64b1889] Randomize order of orphaned data recovery (#3917) [Theo Ilie]
- 2022-09-22 [56ab786] [PAY-604] Use /abuse endpoint in Identity (#3860) [Michael Piazza]
- 2022-09-22 [0eff09d] Default foundation spIDs to reconfig blacklist (#3901) [vicky :)]
- 2022-09-21 [b5dd929] Bump to version 0.3.67 (#3913) [Sid Sethi]
- 2022-09-21 [c2c9502] Fix artist name sorter (#3912) [Raymond Jacobson]
- 2022-09-21 [da6aeeb] INF-251 use set-tag for prod (#3911) [Joaquin Casares]
- 2022-09-21 [945ba42] INF-251 Allow for surgical deployments via a trigger pipeline (#3910) [Joaquin Casares]
- 2022-09-21 [04be7bb] bump connection pool max (#3909) [Johannes Naylor]
- 2022-09-21 [0a05746] remove start time from slack alert (#3907) [Johannes Naylor]
- 2022-09-21 [41c0ac7] Creator node Track owner validation from discovery (#3851) [Joseph Lee]
- 2022-09-21 [8a4cb0c] Increase CN nginx worker procs + Update caching rules (#3883) [Sid Sethi]
- 2022-09-20 [1712c8c] Add a route to start a stripe session in SDK (#3878) [Marcus Pasell]
- 2022-09-20 [8fbd03d] INF deploy-master-hold (#3902) [Joaquin Casares]
- 2022-09-20 [77fcfc3] [PAY-568] Add route to identity to create a Stripe session (#3879) [Marcus Pasell]
- 2022-09-20 [d9c8474] INF-251 Automate Production Deployments (#3893) [Joaquin Casares]
- 2022-09-20 [84d3f28] Make block explorer optional (#3894) [Cheran]
- 2022-09-20 [400b146] Add feeling lucky API to libs (#3895) [Isaac Solo]
- 2022-09-20 [c17637c] Add feeling lucky route (#3896) [Isaac Solo]
- 2022-09-20 [989b35d] Change tsconfig root dir (#3900) [vicky :)]
- 2022-09-20 [7ab9807] Also log aborts in issuing sync flow (#3899) [vicky :)]
- 2022-09-20 [c63975f] Include 2 new challenges in notification tests (#3889) [Reed]
- 2022-09-20 [4bc1e73] Add FsInstrumentation to content node (#3898) [Johannes Naylor]
- 2022-09-19 [b201438] More grafana granularity and track sync failure per wallet (#3886) [vicky :)]
- 2022-09-19 [89545fb] [CON-395] Add duration to network monitoring metrics (#3891) [Johannes Naylor]
- 2022-09-19 [5d613e4] Run is_available job every 3 hours (#3892) [Raymond Jacobson]
- 2022-09-19 [5c199d6] INF clear exporter's tallies for new proposals (#3885) [Joaquin Casares]
- 2022-09-19 [fb87b2e] INF production Grafana snapshot (#3890) [Joaquin Casares]
- 2022-09-19 [64fb281] Fix email deliverable field (#3888) [Michael Piazza]
- 2022-09-19 [95cc726] [CON-395] Add start time to network monitoring slack alert (#3887) [Johannes Naylor]
- 2022-09-19 [05d7766] Clean up sanity checks (#3658) [Dheeraj Manjunath]
- 2022-09-19 [e12947e] Add auth headers cmd for local dev (#3852) [Cheran]
- 2022-09-19 [d9a7b36] Add ESLint rules to prevent easy errors (#3884) [Johannes Naylor]
- 2022-09-19 [9d7d567] Remove snapback init from serviceRegistry (#3882) [Theo Ilie]
- 2022-09-18 [cfbe6d4] Add aborts for primary sync from secondary (#3877) [vicky :)]
- 2022-09-18 [9720cb9] Set reconfig blacklist (#3871) [vicky :)]
- 2022-09-16 [22a3f66] First Playlist and Tip Challenge Playlist Notifications (#3880) [Reed]
- 2022-09-16 [d87f1db] INF-194 Add staging deploys to CircleCi (#3545) [Joaquin Casares]
- 2022-09-16 [c5ef7ea] Update final retry call and add async retry tests (#3844) [vicky :)]
- 2022-09-15 [eac4bb7] [INF-187] Add elastic search to discovery provider (#3800) [Cheran]
- 2022-09-15 [31a81c1] Increase node mem in cnode (#3876) [Raymond Jacobson]
- 2022-09-14 [6f255c5] Fix generated types (#3873) [Saliou Diallo]
- 2022-09-14 [8fc2753] Remove redundant stack trace log (#3872) [vicky :)]
- 2022-09-14 [d46fbab] Test apply early limit true (#3870) [Joseph Lee]
- 2022-09-14 [baed51d] Breakup try catch in audius libs init (#3869) [vicky :)]
- 2022-09-14 [bf379dc] Add multi-root VSCode workspace (#3866) [Michael Piazza]
- 2022-09-14 [93098e4] double snapbackUsersPerJob (#3868) [Sid Sethi]
- 2022-09-14 [cd7681f] Enable all reconfig modes on prod by default (#3858) [Sid Sethi]
- 2022-09-14 [51d0eff] Bump sdk to v1.0.5 [audius-infra]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@dmanjunath dmanjunath dmanjunath approved these changes

@SidSethi SidSethi SidSethi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/M

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@vicky-g @dmanjunath @SidSethi