Fix solana programs admin key naming#3013
Merged
Merged
Conversation
| "anchorAdminPrivateKey": "$admin_keypair_privatekey", | ||
| "anchorAdminStoragePublicKey": "$admin_storage_keypair_publickey", | ||
| "anchorAdminStoragePrivateKey": "$admin_storage_keypair_privatekey", | ||
| "anchorAdminPublicKey": "$admin_authority_keypair_publickey", |
Contributor
There was a problem hiding this comment.
are there references to these values that we have to propagate? in local setup for DP etc.
Author
There was a problem hiding this comment.
i think so! i've got a follow up PR that will rename even more but wanted to unblock first.
#3011
jowlee
approved these changes
May 2, 2022
03add7b to
1ae1811
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Currently, solana-programs container is broken and doesn't seed the first solana transactions. This change fixes that but leaves the rest of the naming aside for https://github.com/AudiusProject/audius-protocol/pull/3011/files.
Tests
solana-programs start works.
How will this change be monitored? Are there sufficient logs?
No monitoring.