Skip to content

[PAY-3585] Prevent async account fetch from delaying left nav if account is cached #10403

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
schottra merged 1 commit into from
Nov 8, 2024
Merged

[PAY-3585] Prevent async account fetch from delaying left nav if account is cached #10403

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/mobile/ios/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2407,4 +2407,4 @@ SPEC CHECKSUMS:

PODFILE CHECKSUM: 5a7fd542b0e975255433e61e18b2041151e970bd

COCOAPODS: 1.13.0
COCOAPODS: 1.15.2

@raymondjacobson raymondjacobson Nov 8, 2024

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oop maybe ok? i am on 1.13 still locally though

@schottra schottra Nov 8, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we are quite mixed on the team at the moment, several folks on latest xcode and tooling. But I can remove this change, doesn't need to be part of this PR.

9 changes: 7 additions & 2 deletions packages/web/src/common/store/account/sagas.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { userApiFetchSaga } from '@audius/common/api'
import { ErrorLevel, Kind } from '@audius/common/models'
import { ErrorLevel, Kind, Status } from '@audius/common/models'
import {
FeatureFlags,
recordIP,
Expand Down Expand Up @@ -186,7 +186,12 @@ export function* fetchAccountAsync({ isSignUp = false }) {
const authService = yield getContext('authService')
const audiusBackendInstance = yield getContext('audiusBackendInstance')

yield put(accountActions.fetchAccountRequested())
const accountStatus = yield select(accountSelectors.getAccountStatus)

// Don't revert successful local account fetch
if (accountStatus !== Status.SUCCESS) {
yield put(accountActions.fetchAccountRequested())
}

const { accountWalletAddress: wallet, web3WalletAddress } = yield call([
authService,
Expand Down