Skip to content

Add reply comment animation to web #10292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Kyle-Shanks merged 2 commits into from
Oct 31, 2024
Merged

Add reply comment animation to web #10292

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e7ad358
Add reply comment animation to web
Kyle-Shanks Oct 31, 2024
1638416
fix lint
Kyle-Shanks Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
68 changes: 38 additions & 30 deletions packages/web/src/components/comments/CommentThread.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,37 +97,45 @@ export const CommentThread = ({ commentId }: { commentId: ID }) => {
: messages.hideReplies}
</PlainButton>
</Box>
{hiddenReplies[rootComment.id] ? null : (
<Flex
direction='column'
gap='l'
as='ul'
aria-label={messages.replies}
>
{replies.map((reply: ReplyComment) => (
<Flex w='100%' key={reply.id} as='li'>
<CommentBlock
commentId={reply.id}
parentCommentId={rootComment.id}
/>
</Flex>
))}
</Flex>
)}

{hasMoreReplies && !hiddenReplies[rootComment.id] ? (
<PlainButton
onClick={handleLoadMoreReplies}
variant='subdued'
css={{ width: 'max-content' }}
disabled={isFetchingReplies}
>
{messages.showMoreReplies}
{isFetchingReplies ? (
<LoadingSpinner css={{ width: 20, height: 20 }} />
<Box

@dylanjeffers dylanjeffers Oct 31, 2024

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting solution, where you get this from?

@Kyle-Shanks Kyle-Shanks Oct 31, 2024

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that flex box could do this, but after trying it didn't work out so after some googling i saw that grid worked in the way that I wanted

css={{
display: 'grid',
gridTemplateRows: hiddenReplies[rootComment.id] ? '0fr' : '1fr',
transition: 'grid-template-rows 0.25s ease-out'
}}
>
<Flex direction='column' gap='l' css={{ overflow: 'hidden' }}>
<Flex
direction='column'
gap='l'
as='ul'
aria-label={messages.replies}
>
{replies.map((reply: ReplyComment) => (
<Flex w='100%' key={reply.id} as='li'>
<CommentBlock
commentId={reply.id}
parentCommentId={rootComment.id}
/>
</Flex>
))}
</Flex>

{hasMoreReplies ? (
<PlainButton
onClick={handleLoadMoreReplies}
variant='subdued'
css={{ width: 'max-content' }}
disabled={isFetchingReplies}
>
{messages.showMoreReplies}
{isFetchingReplies ? (
<LoadingSpinner css={{ width: 20, height: 20 }} />
) : null}
</PlainButton>
) : null}
</PlainButton>
) : null}
</Flex>
</Box>
</Flex>
) : null}
</Flex>
Expand Down
10 changes: 9 additions & 1 deletion packages/web/src/components/composer-input/ComposerInput.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,15 @@ export const ComposerInput = (props: ComposerInputProps) => {
submittedRef.current = false
setUserMentions([])
setUserIdMap({})
}, [getUserMentions, linkEntities, onSubmit, restoreLinks, userIdMap, value])
}, [
blurOnSubmit,
getUserMentions,
linkEntities,
onSubmit,
restoreLinks,
userIdMap,
value
])

// Submit when pressing enter while not holding shift
const handleKeyDown = useCallback(
Expand Down