Skip to content

Fix validations for unreact comment #10246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacsolo merged 1 commit into from
Oct 28, 2024
Merged

Fix validations for unreact comment #10246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions packages/discovery-provider/integration_tests/tasks/entity_manager/test_comment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,20 @@ def test_invalid_comment(app, mocker):
)
},
],
"UnreactCommentNotExisting": [
{
"args": AttributeDict(
{
"_entityId": 1,
"_entityType": "Comment",
"_userId": 1,
"_action": "Unreact",
"_metadata": "",
"_signer": "user1wallet",
}
)
},
],
}

db, index_transaction = setup_test(app, mocker, entities, tx_receipts)
Expand All @@ -269,6 +283,8 @@ def test_invalid_comment(app, mocker):
session.query(Track).filter(Track.pinned_comment_id != None).all()
)
assert len(pinned_comments) == 0
comment_reactions: List[CommentReaction] = session.query(CommentReaction).all()
assert len(comment_reactions) == 0


def test_comment_reply(app, mocker):
Expand Down
10 changes: 9 additions & 1 deletion packages/discovery-provider/src/tasks/entity_manager/entities/comment.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -506,6 +506,14 @@ def validate_comment_reaction_tx(params: ManageEntityParameters):
raise IndexingValidationError(
f"User {user_id} already reacted to comment {comment_id}"
)
if (
params.action == Action.UNREACT
and (user_id, comment_id)
not in params.existing_records[EntityType.COMMENT_REACTION.value]
):
raise IndexingValidationError(
f"User {user_id} has not reacted to comment {comment_id}"
)


def react_comment(params: ManageEntityParameters):
Expand Down Expand Up @@ -613,7 +621,7 @@ def react_comment(params: ManageEntityParameters):


def unreact_comment(params: ManageEntityParameters):
validate_signer(params)
validate_comment_reaction_tx(params)
comment_id = params.entity_id
user_id = params.user_id

Expand Down