Skip to content

[PAY-3499, PAY-3500] Fix truncation on blasts with content audience #10010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amendelsohn merged 2 commits into from
Oct 10, 2024
Merged

[PAY-3499, PAY-3500] Fix truncation on blasts with content audience #10010

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fa0eed8
[PAY-3499] Fix overflow on ChatListBlastItem with long names
amendelsohn Oct 10, 2024
b121fc4
[PAY-3500] Fix truncation on ChatBlastHeader
amendelsohn Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/web/src/pages/chat-page/components/ChatBlastHeader.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,15 +37,16 @@ export const ChatBlastHeader = ({ chat }: { chat: ChatBlast }) => {
<Artwork
src={audienceContentType === 'track' ? trackArtwork : albumArtwork}
w='48px'
css={{ flexShrink: 0 }}
/>
) : null}
<Flex column gap='xs' alignItems='flex-start'>
<Flex gap='s' alignItems='center'>
<IconTowerBroadcast size='m' color='default' />
<Text variant='title' size='l' ellipses>
<Text variant='title' size='l'>
{chatBlastSecondaryTitle}
</Text>
<Text variant='title' size='l' color='subdued' ellipses>
<Text variant='title' size='l' color='subdued' maxLines={1}>
{contentTitle}
</Text>
</Flex>
Expand Down
22 changes: 8 additions & 14 deletions packages/web/src/pages/chat-page/components/ChatListBlastItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { useCallback } from 'react'

import { useChatBlastAudienceContent } from '@audius/common/hooks'
import { formatCount } from '@audius/common/utils'
import { Flex, IconTowerBroadcast, IconUser, Text } from '@audius/harmony'
import { Box, Flex, IconTowerBroadcast, IconUser, Text } from '@audius/harmony'
import { ChatBlast } from '@audius/sdk'
import cn from 'classnames'

Expand Down Expand Up @@ -41,21 +41,15 @@ export const ChatListBlastItem = (props: ChatListBlastItemProps) => {
onClick={handleClick}
className={cn(styles.root, { [styles.active]: isCurrentChat })}
>
<Flex gap='s' css={{ overflow: 'hidden' }}>
<Flex row gap='s' w='100%'>
<IconTowerBroadcast size='l' color='default' />
<Text size='l' strength='strong' css={{ whiteSpace: 'nowrap' }}>
{chatBlastTitle}
</Text>
<Box css={{ flexShrink: 0 }}>
<Text size='l' strength='strong'>
{chatBlastTitle}
</Text>
</Box>
{contentTitle ? (
<Text
size='l'
color='subdued'
css={{
whiteSpace: 'nowrap',
overflow: 'hidden',
textOverflow: 'ellipsis'
}}
>
<Text size='l' color='subdued' ellipses css={{ display: 'block' }}>
{contentTitle}
</Text>
) : null}
Expand Down