Add showname and selfname colors to courtroom_fonts.ini #672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
if anyone can make a settings option for me that'd be amazing <3 |
oldmud0
reviewed
Feb 23, 2022
Member
oldmud0
left a comment
There was a problem hiding this comment.
It's ok. Just a lot of boilerplate I guess.
Co-authored-by: oldmud0 <[email protected]>
Co-authored-by: oldmud0 <[email protected]>
This reverts commit b8df13e.
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
oldmud0
approved these changes
Mar 19, 2022
Member
oldmud0
left a comment
There was a problem hiding this comment.
we should add ic_chatlog_selfname_color, ic_chatlog_showname_color to courtroom_fonts for the default theme, even if we're not actually changing the colors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cyan = selfname, light gray = other name
To implement, in
courtroom_fonts.ini:Closes #671
Also overhauls
chatlogpiece.cppandchatlogpiece.hslightlyTODO: a settings option to ignore selfname