(ready) improved felist key buffer usage to stop when releasing key up/down#393
Merged
ryfactor merged 10 commits intoJun 11, 2018
Merged
Conversation
update from main
(ready) New monsters (Attnam#349)
update from main
(ready) bug fix for show items under (Attnam#369)
(ready) Fantasy name generator (Attnam#363)
update from main
…n we release the key fix: changed sfx option text to "use sound effects" to not confuse with music
Contributor
Author
|
wait, EDIT: I think it is fixed, let me play... err.. test it some more :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem most visible when you got low fps.
On a felist like drop item, with scaled silhouette enabled (what will lower fps),
if you hold key up/down it may keep processing that buffered key for about 3 seconds!!
what could turn one or 2 pages more of items, quite annoying...
now, as soon you release the navigation key up/down it will promptly stop processing the buffer.
obs.: also made it more clear the sfx option text.