#4000 fix(cypher): SET propagates to all aliases bound to the same node

[robfrank]

Summary

Fixes #4000.

When two Cypher variables are bound to the same node, a SET through one alias left the other alias stale in the same result row:

MATCH (n:Person {name:'Alice'}), (m:Person {name:'Alice'})
SET n.age = 35
RETURN n.age AS n_age, m.age AS m_age
-- Was returning: 35, 30  (m stale)
-- Now returns:   35, 35  (both consistent)

Root cause: SetStep.java called doc.modify() to get a MutableDocument, saved it, then updated only the single variable named in the SET item. Any other result-row entries pointing to the same underlying node (by RID) kept their old immutable snapshot.

Fix: Added propagateUpdateToSameNodeAliases() - after saving the mutated document, it scans every property in the result row and replaces any Document whose getIdentity() matches the original RID with the updated document. Applied in applyPropertySet, applyReplaceMap, and applyMergeMap.

Test plan

• setThroughOneAliasPropagatestoOtherAliasOnSameNode - reproduces the main issue (two aliases in same MATCH)
• setThroughOneAliasPropagatestoOtherAliasOnSameNodeFullNode - reproduces the stronger WITH+MATCH reproducer from the issue
• All 15 tests in OpenCypherSetTest pass
• Full OpenCypher suite: 5390 tests, 0 new failures

🤖 Generated with Claude Code

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Coverage 83.33% diff coverage · -8.36% coverage variation

Metric	Results
Coverage variation	✅ -8.36% coverage variation
Diff coverage	✅ 83.33% diff coverage

View coverage diff in Codacy

Coverage variation details

	Coverable lines	Covered lines	Coverage
Common ancestor commit (4ad4748)	120048	88335	73.58%
Head commit (93c62af)	151301 (+31253)	98678 (+10343)	65.22% (-8.36%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details

	Coverable lines	Covered lines	Diff coverage
Pull request (#4004)	18	15	83.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}

[gemini-code-assist]

Code Review

This pull request introduces a mechanism to propagate node updates across all aliases within a result row in OpenCypher queries, ensuring consistency when multiple references point to the same node. This is implemented via a new propagateUpdateToSameNodeAliases method in SetStep.java and verified with new test cases. The review feedback identifies that this propagation logic is missing from the applyLabels method, which could lead to stale data when labels are changed, and suggests an optimization to the propagation loop to avoid redundant property updates.

[gemini-code-assist]

The applyLabels method (starting at line 261) is missing this propagation logic. When a vertex's labels are updated in ArcadeDB, it often results in the creation of a new vertex instance and the deletion of the old one (especially if the underlying type changes). Without calling propagateUpdateToSameNodeAliases in applyLabels, any other aliases in the same result row will continue to point to the old, deleted vertex instance. This will lead to stale data or errors in subsequent query steps. Please ensure that applyLabels also propagates the update to all aliases bound to the same node.

[codecov]

Codecov Report

❌ Patch coverage is 61.11111% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 64.18%. Comparing base (4ad4748) to head (93c62af).
⚠️ Report is 2 commits behind head on main.

Files with missing lines	Patch %	Lines
...adedb/query/opencypher/executor/steps/SetStep.java	61.11%	3 Missing and 4 partials ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4004      +/-   ##
==========================================
- Coverage   64.59%   64.18%   -0.41%     
==========================================
  Files        1597     1597              
  Lines      120048   120062      +14     
  Branches    25551    25556       +5     
==========================================
- Hits        77545    77066     -479     
- Misses      31743    32342     +599     
+ Partials    10760    10654     -106     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.