fix: adapt test so it does not fail randomly in MacOS

[gramian]

What does this PR do?

This change fixes the queryDate test from failing randomly under MacOS by moving the assertion out of the transaction.

Motivation

Often failing test during dev

Checklist

• I have run the build using mvn clean package command
• My unit tests cover both failure and success scenarios

[gemini-code-assist]

Summary of Changes

Hello @gramian, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a non-deterministic test failure that was specifically occurring on macOS environments. By refactoring the queryDate test to perform its assertion outside of the database transaction, it eliminates the race condition or timing issue that caused intermittent failures, thereby significantly improving the reliability and stability of the test suite.

Highlights

• Test Stability: The queryDate test in SQLFunctionsTest.java was experiencing random failures on macOS. This pull request resolves the issue by relocating the assertion logic outside of the database transaction block, ensuring consistent and reliable test outcomes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

The change to move the assertion out of the transaction to fix a flaky test is logical. However, the pull request introduces resource leaks by not closing ResultSet objects. I've added two comments highlighting these issues and provided a suggestion for one of them to ensure resources are properly managed.

[gemini-code-assist]

Removing this assertion makes the result2 variable from the previous line unused. More importantly, the ResultSet it holds is not closed, which causes a resource leak. The UPDATE command should be executed in a way that ensures its ResultSet is closed, for example by using a try-with-resources block, even if the result is not used.

[gemini-code-assist]

The ResultSet returned by database.command is not being closed, which can lead to a resource leak. It's best practice to ensure the ResultSet is always closed. One way to achieve this is to consume and close it, for example by collecting the results into a list via a stream.

Suggested change

	result = database.command("sql", "select count(*) as tot from Account where created is not null");
	assertThat(result.hasNext()).isTrue();
	assertThat(result.next().<Long>getProperty("tot")).isEqualTo(tot);
	java.util.List<com.arcadedb.query.sql.executor.Result> results = database.command("sql", "select count(*) as tot from Account where created is not null").stream().collect(java.util.stream.Collectors.toList());
	assertThat(results).hasSize(1);
	assertThat(results.get(0).<Long>getProperty("tot")).isEqualTo(tot);

[robfrank]

LGTM