Skip to content

Made the close/kill database exception proof to unlock the file once …#111

Merged
lvca merged 105 commits into
mainfrom
windows-issues
Oct 12, 2021
Merged

Made the close/kill database exception proof to unlock the file once …#111
lvca merged 105 commits into
mainfrom
windows-issues

Conversation

@lvca

@lvca lvca commented Oct 7, 2021

Copy link
Copy Markdown
Member

Try to understand why the delete of lock file doesn't work

@lvca lvca self-assigned this Oct 7, 2021
@lvca lvca added the bug label Oct 7, 2021
@lvca lvca added this to the 21.10.2 milestone Oct 12, 2021
@lvca
lvca merged commit d0333cb into main Oct 12, 2021
@lvca lvca linked an issue Oct 12, 2021 that may be closed by this pull request
@lvca
lvca deleted the windows-issues branch October 14, 2021 16:01
mergify Bot added a commit that referenced this pull request Dec 8, 2025
…2.8.32 to 2.9.4 in /studio [skip ci]

Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.8.32 to 2.9.4.
Release notes

*Sourced from [baseline-browser-mapping's releases](https://github.com/web-platform-dx/baseline-browser-mapping/releases).*

> v2.9.3 - remove `process.loadEnvFile()`
> ---------------------------------------
>
> What's Changed
> --------------
>
> * Remove process.loadEnfFile() from main script by [`@​tonypconway`](https://github.com/tonypconway) in [web-platform-dx/baseline-browser-mapping#112](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/pull/112)
>
> **Full Changelog**: <web-platform-dx/baseline-browser-mapping@v2.9.2...v2.9.3>
>
> v2.9.2 - fix browser support bug
> --------------------------------
>
> What's Changed
> --------------
>
> * Fix browser support bug by [`@​tonypconway`](https://github.com/tonypconway) in [web-platform-dx/baseline-browser-mapping#111](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/pull/111)
>   **Full Changelog**: <web-platform-dx/baseline-browser-mapping@v2.9.1...v2.9.2>
>
> v2.9.0 - Reduce frequency of data staleness warnings
> ----------------------------------------------------
>
> This version introduces a number of changes to data staleness warnings in response to [#105](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/105) , [#107](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/107) and [#109](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/109)
>
> * Data staleness warnings are now only shown if the `getCompatibleVersions()` or `getAllVersions()` functions are called - previously they were shown whenever the module was loaded, which meant many `browserslist` consumers were seeing the warning despite not targeting Baseline, especially those who were consuming `browserslist` in a pre-compiled format via `next.js`.
> * Adds new conditions for these warnings to be displayed which should only warn users for whom data freshness is critical:
>   + The feature cut off data must be within the last two months, i.e. `widelyAvailableOnDate: today + >2 years and 4 months` or `newly available` in a `browserslist` query.
>   + The module data must be more than 2 months old.
> * Introduces suppression options for these warning via the `options` objects and environment variables:
>   + Adds a new `suppressWarnings` boolean to the `getCompatibleVersions()` and `getAllVersions()`
>   + Respects the existing [`BROWSERSLIST_IGNORE_OLD_DATA`](browserslist/browserslist@0ae7155) environment variable.
>   + Respects a new `BASELINE_BROWSER_MAPPING_IGNORE_OLD_DATA` environment variable.
> * Adds [explanatory text to the README](https://github.com/web-platform-dx/baseline-browser-mapping?tab=readme-ov-file#keeping-baseline-browser-mapping-up-to-date) for how to avoid such warnings when reproducible builds are a requirement.
> * Change warning text to be package manager agnostic and mention the possibility of pre-compiled data.


Commits

* [`73c8429`](web-platform-dx/baseline-browser-mapping@73c8429) Patch to 2.9.4 because browser or feature data changed
* [`079e1d9`](web-platform-dx/baseline-browser-mapping@079e1d9) Browser or feature data changed
* [`3553f31`](web-platform-dx/baseline-browser-mapping@3553f31) Remove process.loadEnfFile() from main script ([#112](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/112))
* [`5972583`](web-platform-dx/baseline-browser-mapping@5972583) Bump version from 2.9.1 to 2.9.2
* [`0ab0d6f`](web-platform-dx/baseline-browser-mapping@0ab0d6f) Fix browser support bug ([#111](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/111))
* [`b326475`](web-platform-dx/baseline-browser-mapping@b326475) Patch to 2.9.1 because browser or feature data changed
* [`9ee8cbe`](web-platform-dx/baseline-browser-mapping@9ee8cbe) Browser or feature data changed
* [`226fd01`](web-platform-dx/baseline-browser-mapping@226fd01) Reduce frequency of data staleness warnings ([#108](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/108))
* [`6d43e5a`](web-platform-dx/baseline-browser-mapping@6d43e5a) Updating static site
* See full diff in [compare view](web-platform-dx/baseline-browser-mapping@v2.8.32...v2.9.4)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=baseline-browser-mapping&package-manager=npm\_and\_yarn&previous-version=2.8.32&new-version=2.9.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
tae898 pushed a commit to humemai/arcadedb-embedded-python that referenced this pull request Jun 28, 2026
Main things:
- properly closed all files in tests
- keep track of created database instances to check about multiple instances over the same database

Details:

* ArcadeData#109 add windows runner to matrix

* ArcadeData#109 add windows runner to matrix: fix

* ArcadeData#109 add windows runner to matrix: fix

* ArcadeData#109 add -Dsurefire.useFile=false

* ArcadeData#109 add quotes for windows

* Made the close/kill database exception proof to unlock the file once done

* Fixed closing of database

* Another fix on database

* Restored close database

* ArcadeData#109 publish reports only for ubuntu running

* ArcadeData#109 replace double quotes with single quotes

* ArcadeData#109 add new test reporer

* Restored db.kill()

* ArcadeData#109 removed token

* Checking why is failing on windows

* Avoid locking under windows

* Closed correctly files after channels

* Properly delete the lock file

* Added logs to figure out what's going on on Windows

* Changed delete of lock file

* Added more logs

* Restored lock database

* Skip locking of files under Windows

* Removed unused logs and added warning in case some files are not properly removed at db.close()

* Removed debug output

* Added call to GC in case the file can't be deleted

* Using Files.delete() to delete files in order to get the detailed exception

* Using Files.delete in multiple points

* Fixed test cases on Windows that use kill to simulate a hard shutdown

* Avoid to remove WAL file on kill() (test only)

* Added more logs to discover the issue under windows

* WAL delete now uses the retry+gc under windows

* Logs

* Changed log level

* Fixed ACID test case under windows

* Fixed kill

* Fixed txManager.kill() to release active WAL files

* Fixed issue with kill()

* Removed logs

* Added some logs

* Debug windows

* Debug on windows

* Fixed (maybe) issue with Windows paths

* Debug windows wal issue

* Managed rename exception in indexes for windows issue

* Added more logs

* Fixed rename under windows + temp disabled acid test

* Debug logs

* Modified rename of temp file index

* Update PaginatedFile.java

* Update PaginatedFile.java

* Update LSMTreeIndexAbstract.java

* Fixed rename of index files

* Last change to fix issues under windows

* Minor fixes for tests

* Added logs

* Improved logs

* Fixed not closed WAL file problem

* Removed logs on wal file

* Disabled Gremlin tests on windows because of a bug in gremlin tests

* Update mvn-test.yml

* Disabled gremlin tests on windows

* add profile to maven for windows to exclude gremlin tests

* back to surefire reporter

* enable new reporter

* add continue-on-error

* add fali-fast false to avoid stop the ubuntu build

* comment continue-on-error

* test report os too big, limit report to failed tests

* test another reporter

* fox check name position

* fox check name position

* Added logs for database lock

* Fixed database drop with test files

* Forced closing on kill() test method

* Fixed closing of file security .jsonl

* Fixed reading of security files: files could be left open

* Drop databases after the test

* Fixed more tests

* Fixed drop databases at the end of the test

* Update BaseGraphServerTest.java

* Removed all automatic parallel settings in tests (`Runtime.getRuntime().availableProcessors()`). Now the base is always  to have predictable results across hw/sw cfgs

* Properly dropped database from a series of tests

* Forced deletion of all WAL file at closing if no errors are found

* Fixed delete of database after test

* Created database factory static instances for tracking open databases in tests

* Fixed tests

* Update LSMTreeFullTextIndexTest.java

* Fixed test

* Prevent closing/dropping of database instances taken from the server

* Using wrapped database for drop

* Deleted imported databases after test

* Fixed MongoDB tests

* Fixed backup/restore path

* Removed default databases after test

Co-authored-by: arcade-player <arcade@arcadeanalytics.com>
tae898 pushed a commit to humemai/arcadedb-embedded-python that referenced this pull request Jun 28, 2026
…2.8.32 to 2.9.4 in /studio [skip ci]

Bumps [baseline-browser-mapping](https://github.com/web-platform-dx/baseline-browser-mapping) from 2.8.32 to 2.9.4.
Release notes

*Sourced from [baseline-browser-mapping's releases](https://github.com/web-platform-dx/baseline-browser-mapping/releases).*

> v2.9.3 - remove `process.loadEnvFile()`
> ---------------------------------------
>
> What's Changed
> --------------
>
> * Remove process.loadEnfFile() from main script by [`@​tonypconway`](https://github.com/tonypconway) in [web-platform-dx/baseline-browser-mapping#112](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/pull/112)
>
> **Full Changelog**: <web-platform-dx/baseline-browser-mapping@v2.9.2...v2.9.3>
>
> v2.9.2 - fix browser support bug
> --------------------------------
>
> What's Changed
> --------------
>
> * Fix browser support bug by [`@​tonypconway`](https://github.com/tonypconway) in [web-platform-dx/baseline-browser-mapping#111](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/pull/111)
>   **Full Changelog**: <web-platform-dx/baseline-browser-mapping@v2.9.1...v2.9.2>
>
> v2.9.0 - Reduce frequency of data staleness warnings
> ----------------------------------------------------
>
> This version introduces a number of changes to data staleness warnings in response to [ArcadeData#105](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/105) , [ArcadeData#107](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/107) and [ArcadeData#109](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/109)
>
> * Data staleness warnings are now only shown if the `getCompatibleVersions()` or `getAllVersions()` functions are called - previously they were shown whenever the module was loaded, which meant many `browserslist` consumers were seeing the warning despite not targeting Baseline, especially those who were consuming `browserslist` in a pre-compiled format via `next.js`.
> * Adds new conditions for these warnings to be displayed which should only warn users for whom data freshness is critical:
>   + The feature cut off data must be within the last two months, i.e. `widelyAvailableOnDate: today + >2 years and 4 months` or `newly available` in a `browserslist` query.
>   + The module data must be more than 2 months old.
> * Introduces suppression options for these warning via the `options` objects and environment variables:
>   + Adds a new `suppressWarnings` boolean to the `getCompatibleVersions()` and `getAllVersions()`
>   + Respects the existing [`BROWSERSLIST_IGNORE_OLD_DATA`](browserslist/browserslist@0ae7155) environment variable.
>   + Respects a new `BASELINE_BROWSER_MAPPING_IGNORE_OLD_DATA` environment variable.
> * Adds [explanatory text to the README](https://github.com/web-platform-dx/baseline-browser-mapping?tab=readme-ov-file#keeping-baseline-browser-mapping-up-to-date) for how to avoid such warnings when reproducible builds are a requirement.
> * Change warning text to be package manager agnostic and mention the possibility of pre-compiled data.


Commits

* [`73c8429`](web-platform-dx/baseline-browser-mapping@73c8429) Patch to 2.9.4 because browser or feature data changed
* [`079e1d9`](web-platform-dx/baseline-browser-mapping@079e1d9) Browser or feature data changed
* [`3553f31`](web-platform-dx/baseline-browser-mapping@3553f31) Remove process.loadEnfFile() from main script ([#112](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/112))
* [`5972583`](web-platform-dx/baseline-browser-mapping@5972583) Bump version from 2.9.1 to 2.9.2
* [`0ab0d6f`](web-platform-dx/baseline-browser-mapping@0ab0d6f) Fix browser support bug ([ArcadeData#111](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/111))
* [`b326475`](web-platform-dx/baseline-browser-mapping@b326475) Patch to 2.9.1 because browser or feature data changed
* [`9ee8cbe`](web-platform-dx/baseline-browser-mapping@9ee8cbe) Browser or feature data changed
* [`226fd01`](web-platform-dx/baseline-browser-mapping@226fd01) Reduce frequency of data staleness warnings ([ArcadeData#108](https://redirect.github.com/web-platform-dx/baseline-browser-mapping/issues/108))
* [`6d43e5a`](web-platform-dx/baseline-browser-mapping@6d43e5a) Updating static site
* See full diff in [compare view](web-platform-dx/baseline-browser-mapping@v2.8.32...v2.9.4)
  
[![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility\_score?dependency-name=baseline-browser-mapping&package-manager=npm\_and\_yarn&previous-version=2.8.32&new-version=2.9.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
Dependabot commands and options
  
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot show  ignore conditions` will show all of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Embedded mode is not persistent on windows

2 participants