Change default gesture swipes to desktop switching#270
Conversation
Greptile SummarySwaps the default horizontal gesture-swipe actions from browser tab switching (
Confidence Score: 5/5Safe to merge — this is a two-line default value swap with no logic changes, no new variants, and no migration concerns for existing user configs (users who have already customized their gesture bindings are unaffected; only fresh/default installs change). The changed function only seeds defaults for first-run or freshly-promoted gesture buttons; existing persisted configs are never overwritten. Both target actions are valid, well-tested enum variants. The indirect test coverage in config.rs automatically validates the new defaults. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
G[GestureButton swipe] --> D{GestureDirection}
D -->|Up| MC[Action::MissionControl]
D -->|Down| SD[Action::ShowDesktop]
D -->|Left| PD["Action::PreviousDesktop (was PrevTab)"]
D -->|Right| ND["Action::NextDesktop (was NextTab)"]
D -->|Click| AE[Action::AppExpose]
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
G[GestureButton swipe] --> D{GestureDirection}
D -->|Up| MC[Action::MissionControl]
D -->|Down| SD[Action::ShowDesktop]
D -->|Left| PD["Action::PreviousDesktop (was PrevTab)"]
D -->|Right| ND["Action::NextDesktop (was NextTab)"]
D -->|Click| AE[Action::AppExpose]
Reviews (3): Last reviewed commit: "Merge branch 'master' into proposal/defa..." | Re-trigger Greptile |
Summary
Split out from #94 as requested.
This PR changes the default horizontal gesture-button swipes from browser tab switching to desktop/space switching:
Why
AprilNEA asked to keep this UX decision separate from the wheel-scroll settings work, so each change can be reviewed and reverted independently.
The wheel-scroll settings remain in #94. This PR contains only the default gesture remap.
Verification
cargo fmt --allgit diff --checkcargo test -p openlogi-core default_gesture_binding --libwas attempted locally, but dependency fetching hung while updating git dependencies before compilation.