Dialog flickering (continuos vertical resize)

[buttim]

I added the sample code from the README to my app, using more or less the same changelog_master.xml resource.
The result is that the changelog dialog appears but does a continuous vertical resize as in the video attached

video5944858658973161078.mp4

[hannesa2]

It opens a AlertDialog .show()

I'm not sure, what you do on your side. Because only you know the source code, you have to solve this.
And please don't send some code spinets, this makes no sense.
Only a running sample makes sense

[buttim]

Yes I'm aware of the AlertDialog, I checked the code. And I know this won't help you that much in solving the problem. Still wanted to let you know so if somebody else finds the same problem this issue might help him if we ever find a solution. Obviously it does not make much sense to send you the whole app source and it could be quite hard to build a minimal example.

[hannesa2]

it could be quite hard to build a minimal example.

But you have more experience to make such a code 😁
Please Imagine, for me it's much more harder to prepare it

[buttim]

Sure. I wasn't asking to do that. I know you can't do much here, I just thought it might help to have the problem documented. Still working on it without much luck. I do have other (smaller) AlertDialogs opening on the same Activity with no problem. It might be related to the size of the specific content, since none of mine have a WebView inside. I tried to "inflate" one of my AlertDialogs but it did behave well. I will report any finding

[buttim]

I think I nailed it. When the user presses the "MORE..." button you're opening a second alert before the first one gets actually dismissed. This seems to generate a race condition at least on my Android version/brand/phone. I solved it by changing the line in which the "full dialog" is shown like this (this also requires to import android.os.Handler and import android.os.Looper):

        if (!full) {
            // Show "More…" button if we're only displaying a partial change log.
            builder.setNegativeButton(
                R.string.changelog_show_full
            ) { _, _ -> Handler(Looper.getMainLooper()).post{fullLogDialog.show()} }
        }

If you require it I will open a PR, but I think it should be simpler to just copy/paste the line. Let me know

[buttim]

Hold the press... it happened again. My change solved the problem for when the user presses "MORE...", but not for first time (partial history) show

[hannesa2]

You mean this flickers on your side ?

Untitled.mov

and you solved it for you with this ?

if (!full) {
            // Show "More…" button if we're only displaying a partial change log.
            builder.setNegativeButton(
                R.string.changelog_show_full
            ) { _, _ -> Handler(Looper.getMainLooper()).post{fullLogDialog.show()} }
        }

Why I don't see it ?

[buttim]

Nope. Still working in my app. I'm pretty sure in the example I would find no problem.
And yes, I solved half of the problem with that line

[hannesa2]

Please give it a try https://github.com/AppDevNext/ChangeLog/releases/tag/3.7

[buttim]

The problem is still there with 3.7 sadly

[singpolyma]

It seems to happen less often in 3.7.1 but still happens

[hannesa2]

3.7.1 only fixes jitpack.io publish, please see changelog https://github.com/AppDevNext/ChangeLog/releases/tag/3.7.1

[buttim]

Ah, OK. Good to know, thanks