You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@shahor02@ginnocen I produced some prototype for the vertexing to use in O2 with ALICE3, the implementation in DelphesO2 is here https://github.com/preghenella/DelphesO2/pull/36. @shahor02 I followed your suggestions.
Of course it would be useful if we could discuss the details of the implementation, in particular concerning the timestamp parameters, for that I would need your blessing.
I can produce few performance plots to check that everything is consistent.
Hi @njacazio
I don't think this will work: you are creating a pool of tracks with the same dummy min/max timestamp [0:1]. As a result the time and Z clustering done before the vertexing will lead to 1 huge time cluster and all vertices will pile-up together. But Alice3
I am anyway planning to change the input from TrackTPCITS to templated tracks with TrackParCov + TimeStampWithError functionalities.
I can also change the gsl::span<const o2::ft0::RecPoints> ft0Data to span of T providing T.getInteractionRecord() method (the only one used in validation). Then, you can even provide a dummy vector, instead of cloning these methods.
Let me know if this is ok.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@shahor02 @ginnocen I produced some prototype for the vertexing to use in O2 with ALICE3, the implementation in DelphesO2 is here https://github.com/preghenella/DelphesO2/pull/36.
@shahor02 I followed your suggestions.
Of course it would be useful if we could discuss the details of the implementation, in particular concerning the timestamp parameters, for that I would need your blessing.
I can produce few performance plots to check that everything is consistent.