Skip to content

Add TPC QC histograms for (limited) monitoring of cluster rejection on the fly while processing without MC information #5185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 3 commits into from
Jan 14, 2021
Merged

Add TPC QC histograms for (limited) monitoring of cluster rejection on the fly while processing without MC information #5185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1ee7b37
GPU QA: Do not read O2 MC information if MC QA is not requested
davidrohr Jan 14, 2021
5dda76f
GPU QA: Fix segfault when efficiency task is disabled
davidrohr Jan 14, 2021
25ce22d
GPU QA: Add histograms with cluster rejection counts, add more suppor…
davidrohr Jan 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions Detectors/TPC/workflow/src/CATrackerSpec.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,13 +169,16 @@ DataProcessorSpec getCATrackerSpec(CompletionPolicyData* policyData, ca::Config
}
config.configProcessing.runMC = specconfig.processMC;
if (specconfig.outputQA) {
if (!specconfig.processMC) {
if (!specconfig.processMC && !config.configQA.clusterRejectionHistograms) {
throw std::runtime_error("Need MC information to create QA plots");
}
if (!specconfig.processMC) {
config.configQA.noMC = true;
}
config.configQA.shipToQC = true;
if (!config.configProcessing.runQA) {
config.configQA.enableLocalOutput = false;
processAttributes->qaTaskMask = 15;
processAttributes->qaTaskMask = (specconfig.processMC ? 15 : 0) | (config.configQA.clusterRejectionHistograms ? 32 : 0);
config.configProcessing.runQA = -processAttributes->qaTaskMask;
}
}
Expand Down
2 changes: 2 additions & 0 deletions GPU/GPUTracking/Base/GPUSettingsList.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -203,6 +203,8 @@ AddOption(noMC, bool, false, "", 0, "Force running QA without MC labels even if
AddOption(shipToQC, bool, false, "", 0, "Do not write output files but ship histograms for QC")
AddOption(shipToQCAsCanvas, bool, false, "", 0, "Send TCanvases with full layout to QC instead of individual histograms")
AddOption(enableLocalOutput, bool, true, "", 0, "Enable normal output to local PDF files / console")
AddOption(clusterRejectionHistograms, bool, false, "", 0, "Fill histograms with cluster rejection statistics")
AddOption(histMaxNClusters, unsigned int, 500000000, "", 0, "Maximum number of clusters in rejection histograms")
AddShortcut("compare", 0, "--QAinput", "Compare QA histograms", "--qa", "--QAinputHistogramsOnly")
AddHelp("help", 'h')
EndConfig()
Expand Down
Loading