Make TrackPar(Cov) compatible to GPU#5043
Merged
davidrohr merged 9 commits intoAliceO2Group:devfrom Dec 12, 2020
Merged
Conversation
Collaborator
|
Thank you very much, looking forward to test it. |
… fail on LOG(...) << ...
…tic constexpr is not supported by GPU
53a4c54 to
024170a
Compare
Collaborator
Author
|
@mconcas : FYI: the problems with HIP are solved now. I still need to work on the propagator and then integrate it for the TPC refit, but at least the commits so far should not have side effects, and I'll merge this once the CI passes to have this part in already to have some stable basis to work on and to avoid merge conflicts. |
024170a to
ba96502
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mconcas : This is my current state. It still fails compilation on HIP, but that should not bother your. Let's see if this passes the CI without AMD.
It is so far only TrackPar and TrackParCov, the Propagator will come next.
But I didn't test it yet, just compiled it with CUDA in Standalone mode, will become more mature the next days.
In order to use it:
The TPC GPU code works a bit differently compared to what you do in ITS. There is no separate compilation, but all files are included in the CU files. If you want to keep going with separate compilation, that should not be a problem. Just create a CU file that includes
TrackParametrization.cxxandTrackParametrizationWithErrors.cxx(and later the propagator) and link that together with whatever code you write in your library. Symbols should not collide in theory. Let's see :)