478 amffactory and matrix views #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 26, 2022 11:11
Store only Id IMFs to keep the size. Original IMFs are already fused into the mapping polynomial. Remove obsolete fields and make fused function static.
…inside a single AMF type in StorageBasedMatrix. Offer the following three ways to instantiate AMFs: * AMF belonging to an original container (that requires allocation) * AMF as a result of a gather view using row and column IMFs * AMF as a result of a static view (e.g. transpose, diagonal) Other related changes: * Implement fusion of static IMFs into the storage mapping polynomial. * Add a type trait to extract amf_type from any type (to support invocation for original containers) Change the definition of StorageBasedMatrix: * Encapsulate IMFR, IMFC and polynomial in a single AMF type * Add type traits to determine the AMF type for a given matrix static properties.
added 7 commits
July 28, 2022 17:49
Since Strided IMFs can always be fused into the polynomial, this specialization will never be instantiated.
Instantiate original AMF only through factory and disable making AMF objects outside of AMF factory Disallow AMF copies and enforce move semantics
hidanielesgit
suggested changes
Aug 8, 2022
added 3 commits
August 8, 2022 16:19
Also disable instantiation of these classes
hidanielesgit
approved these changes
Aug 9, 2022
added 2 commits
August 9, 2022 16:33
Also solve inconsistent ordering of imf-type function parameters
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.