Skip to content

Conversation

@C-Achard
Copy link
Collaborator

@C-Achard C-Achard commented Jul 18, 2022

  • Incompatible weights in training are now ignored
  • If weights already exist, the download step is skipped

Further improvements that could be made:

  • Show the expected size of the images from the weights that were downloaded (extract from .pth or manually ?)
  • Add an "always update weights" toggle to allow people to update their local weights easily

C-Achard added 2 commits July 18, 2022 16:12
- Skips download if the weights file is already present
- Skips state_dict loading step in training if the weights are found to be incompatible
- Added signal to emit warning from worker (not functional for now)

- Added clearer warning when weights are not compatible in training
@C-Achard C-Achard added the enhancement New feature or request label Jul 18, 2022
@C-Achard C-Achard requested a review from MMathisLab July 18, 2022 14:53
@C-Achard C-Achard self-assigned this Jul 18, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2022

Codecov Report

Merging #24 (487560d) into main (1709528) will decrease coverage by 0.17%.
The diff coverage is 18.60%.

@@            Coverage Diff             @@
##             main      #24      +/-   ##
==========================================
- Coverage   37.51%   37.34%   -0.18%     
==========================================
  Files          37       37              
  Lines        3417     3449      +32     
==========================================
+ Hits         1282     1288       +6     
- Misses       2135     2161      +26     
Impacted Files Coverage Δ
napari_cellseg3d/models/model_SegResNet.py 45.45% <ø> (ø)
napari_cellseg3d/models/model_TRAILMAP.py 27.08% <ø> (ø)
napari_cellseg3d/models/model_VNet.py 42.85% <ø> (ø)
napari_cellseg3d/plugin_model_inference.py 0.00% <0.00%> (ø)
napari_cellseg3d/plugin_model_training.py 63.36% <0.00%> (-0.17%) ⬇️
napari_cellseg3d/utils.py 33.05% <ø> (ø)
napari_cellseg3d/model_workers.py 16.13% <18.18%> (+0.03%) ⬆️
napari_cellseg3d/log_utility.py 29.78% <25.00%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1709528...487560d. Read the comment docs.

@deprecated-napari-hub-preview-bot

Preview page for your plugin is ready here:
https://preview.napari-hub.org/AdaptiveMotorControlLab/CellSeg3d/24
Created: 2022-07-18T14:59:30.290868

@MMathisLab MMathisLab merged commit ec8ab8b into main Jul 21, 2022
@MMathisLab MMathisLab deleted the cy/download-improvements branch July 21, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants