Skip to content

Conversation

@vidalmaxime
Copy link
Contributor

@vidalmaxime vidalmaxime commented Jul 4, 2022

(WIP) This PR aims to

  • Add SwinUNetR to the modelzoo

  • Remove extra padding during inference which can worsen the predictions when using window inference

  • Removed old TRAILMAP copy

@codecov-commenter
Copy link

codecov-commenter commented Jul 4, 2022

Codecov Report

Merging #12 (bb90f9f) into main (e462c4e) will increase coverage by 0.37%.
The diff coverage is 12.81%.

@@            Coverage Diff             @@
##             main      #12      +/-   ##
==========================================
+ Coverage   37.34%   37.71%   +0.37%     
==========================================
  Files          37       38       +1     
  Lines        3449     3500      +51     
==========================================
+ Hits         1288     1320      +32     
- Misses       2161     2180      +19     
Impacted Files Coverage Δ
napari_cellseg3d/model_instance_seg.py 25.00% <0.00%> (-1.16%) ⬇️
napari_cellseg3d/models/model_TRAILMAP.py 0.00% <0.00%> (-27.09%) ⬇️
napari_cellseg3d/models/model_VNet.py 42.85% <ø> (ø)
napari_cellseg3d/plugin_model_inference.py 0.00% <0.00%> (ø)
napari_cellseg3d/utils.py 50.60% <0.00%> (+17.54%) ⬆️
napari_cellseg3d/model_workers.py 15.56% <4.92%> (-0.58%) ⬇️
napari_cellseg3d/interface.py 84.09% <46.15%> (-2.30%) ⬇️
napari_cellseg3d/models/model_SegResNet.py 45.45% <50.00%> (ø)
napari_cellseg3d/models/model_SwinUNetR.py 54.54% <54.54%> (ø)
napari_cellseg3d/plugin_dock.py 76.74% <64.10%> (+2.18%) ⬆️
... and 5 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@deprecated-napari-hub-preview-bot
Copy link

deprecated-napari-hub-preview-bot bot commented Jul 4, 2022

Preview page for your plugin is ready here:
https://preview.napari-hub.org/AdaptiveMotorControlLab/CellSeg3d/12
Updated: 2022-08-15T11:37:03.760256

@MMathisLab
Copy link
Member

@vidalmaxime can you fix merge conflicts?

@vidalmaxime vidalmaxime marked this pull request as draft July 7, 2022 12:51
Copy link
Collaborator

@C-Achard C-Achard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few comments on the PR @vidalmaxime :) Thanks for the work on the models

@C-Achard C-Achard added enhancement New feature or request ML Related to machine learning : MONAI, Torch... labels Jul 14, 2022
@vidalmaxime
Copy link
Contributor Author

@C-Achard

Removed draft of TRAILMAP port to Pytorch
- Fixed model instantiation
- Fix window overlap argument type error
- Updated reqs.txt to have einops (MONAI optional dep.)
- Added overlap parameter for window
- Improved UI code slightly
@C-Achard
Copy link
Collaborator

Should be ready for review @vidalmaxime, if you could maybe test it quickly some time just to make sure everything is fine, that'd be great

@MMathisLab MMathisLab marked this pull request as ready for review August 12, 2022 12:14
vidalmaxime and others added 8 commits August 12, 2022 16:25
…xed padding only for sliding window inference
Removed draft of TRAILMAP port to Pytorch
- Fixed model instantiation
- Fix window overlap argument type error
- Updated reqs.txt to have einops (MONAI optional dep.)
- Added overlap parameter for window
- Improved UI code slightly
Removed padding transform when using single layer inference and the sliding window inference option
@C-Achard C-Achard self-requested a review August 12, 2022 15:20
- Fixed missing filename for saving layer inference
- Fixed duplicate model init
- Fixed error in model init
- lint
Prepared for SWIN download
- Fixed error in training : get_net erroneous call
@C-Achard
Copy link
Collaborator

@vidalmaxime I think this is ready for merging into main - should we do a new rc on PyPi with the recently added features ?

@C-Achard C-Achard requested a review from MMathisLab August 15, 2022 12:05
@MMathisLab
Copy link
Member

yes, let's make a new pypi, so new PR with the version bumped up!

@MMathisLab MMathisLab merged commit 7363823 into main Aug 15, 2022
@C-Achard C-Achard deleted the feature/swinunetr branch November 21, 2022 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request ML Related to machine learning : MONAI, Torch...

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants