-
Notifications
You must be signed in to change notification settings - Fork 743
Refactor quicktools settings #1761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor quicktools settings #1761
Conversation
Summary of ChangesHello @bajrangCoder, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refactors the quicktools settings to introduce drag and drop features, aiming to provide a more intuitive and user-friendly way for users to customize their quicktools. The changes involve updating various language translation files to include new keys related to active and available tools, laying the groundwork for enhanced personalization. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request refactors the quicktools settings by adding new localization keys for drag and drop features. While the new keys active tools and available tools have been added correctly to all language files, the translations are missing for all languages except English. I've added suggestions to translate these new keys in each respective language file. Please apply these suggestions to ensure a consistent user experience across all supported languages.
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new localization keys for active tools and available tools have not been translated into Belarusian. Please add the translations.
| "active tools": "Active tools", | |
| "available tools": "Available tools" | |
| "active tools": "Актыўныя інструменты", | |
| "available tools": "Даступныя інструменты" |
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new localization keys for active tools and available tools have not been translated into Burmese (Unicode). Please add the translations.
| "active tools": "Active tools", | |
| "available tools": "Available tools" | |
| "active tools": "အသုံးပြုနေသော တူးလ်များ", | |
| "available tools": "ရရှိနိုင်သော တူးလ်များ" |
| "active tools": "Active tools", | ||
| "available tools": "Available tools" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new localization keys for active tools and available tools have not been translated into Burmese (Zawgyi). Please add the translations.
| "active tools": "Active tools", | |
| "available tools": "Available tools" | |
| "active tools": "အသုံးျပဳနေေသာ တူးလ္မ်ား", | |
| "available tools": "ရရွိႏိုင္ေသာ တူးလ္မ်ား" |
UnschooledGamer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM per the SS, I saw for Visual Ref.
Refactor quicktools settings to add drag and drop features with more user-friendly way to customise the quicktools