fix(pdf): fixed issue causing garbled black results#306
Merged
tedwaine merged 2 commits intoJul 9, 2026
Conversation
Many PDF files do not have an explicit background and for them the QPdfDocument render() method produced unpremultiplied RGB over black. This fix composites the rendered result over white for both the "Pages RGB" stream and thumbnails. This leaves the "Pages RGBA" stream over black, but it has been modified to premult the RGB so that if it were composited 'over' a white image it would look correct. Signed-off-by: Ken McGaugh <ken@mcgaugh.co.uk>
c3ab3d6
into
AcademySoftwareFoundation:develop
3 of 4 checks passed
Collaborator
|
Nice one @kenmcgaugh. thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many PDF files do not have an explicit background and for them the QPdfDocument render() method produced unpremultiplied RGB over black. This fix composites the rendered result over white for both the "Pages RGB" stream and thumbnails. This leaves the "Pages RGBA" stream over black, but it has been modified to premult the RGB so that if it were composited 'over' a white image it would look correct.