Skip to content

Support Python 3.9#1080

Merged
ssteinbach merged 2 commits into
AcademySoftwareFoundation:masterfrom
JeanChristopheMorinPerso:python_39
Sep 30, 2021
Merged

Support Python 3.9#1080
ssteinbach merged 2 commits into
AcademySoftwareFoundation:masterfrom
JeanChristopheMorinPerso:python_39

Conversation

@JeanChristopheMorinPerso

@JeanChristopheMorinPerso JeanChristopheMorinPerso commented Sep 24, 2021

Copy link
Copy Markdown
Member

Fixes #828.

Add support for Python 3.9.

I also took the occasion to set the python_requires to explicitly set the supported Python versions and prohibit Python 3.9.0. Additionally I removed the logic around the install requires for Python < 3 to use a more modern and static method.

@codecov-commenter

codecov-commenter commented Sep 24, 2021

Copy link
Copy Markdown

Codecov Report

Merging #1080 (388f08f) into master (1ba6d78) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1080   +/-   ##
=======================================
  Coverage   78.87%   78.87%           
=======================================
  Files         113      113           
  Lines        6124     6124           
=======================================
  Hits         4830     4830           
  Misses       1294     1294           
Flag Coverage Δ
unittests 78.87% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ba6d78...388f08f. Read the comment docs.

Comment thread setup.py

@ssteinbach ssteinbach left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README.md also needs to be updated (badges and so on). Thanks for doing this clean up!

@JeanChristopheMorinPerso

Copy link
Copy Markdown
Member Author

@ssteinbach I modified the README as requested. I also tried to see if there was other references to supported Python versions and couldn't find anything outside what I have in this PR. Let me know if there is more places to update.

@meshula

meshula commented Sep 27, 2021

Copy link
Copy Markdown
Collaborator

@ssteinbach Does the latest push meet your request on documentation and badges?

@ssteinbach

Copy link
Copy Markdown
Collaborator

Yup this looks good. I think we can ask the question of whether we can drop the older VFX platform support and add 2021.

@ssteinbach ssteinbach added this to the Public Beta 14 milestone Sep 30, 2021
@ssteinbach ssteinbach merged commit b4b36a1 into AcademySoftwareFoundation:master Sep 30, 2021
@ssteinbach

Copy link
Copy Markdown
Collaborator

Thanks @JeanChristopheMorinPerso!

@JeanChristopheMorinPerso

Copy link
Copy Markdown
Member Author

I was unsure about the VFX platform version as I wasn't sure if we fully support 2022. For example I don't know if the OTIO UI works with PySide 5.15.x.

@JeanChristopheMorinPerso JeanChristopheMorinPerso deleted the python_39 branch September 30, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Development

Successfully merging this pull request may close these issues.

Python 3.9 Support

4 participants