Skip to content

#803: Replace mutable.Map with concurrent.TrieMap in JobScheduler for runningDags #804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
filiphornak merged 3 commits into from
Apr 18, 2023
Merged

#803: Replace mutable.Map with concurrent.TrieMap in JobScheduler for runningDags #804

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9ec18d4
fix (JobScheduler): Replace mutable.Map with concurrent.Map for runni…
Mar 16, 2023
ee811ff
Merge branch 'develop' into fix/803-runningDags-concurrency-issue
filiphornak Apr 17, 2023
dcab49e
Merge branch 'develop' into fix/803-runningDags-concurrency-issue
filiphornak Apr 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/main/scala/za/co/absa/hyperdrive/trigger/scheduler/JobScheduler.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ import za.co.absa.hyperdrive.trigger.scheduler.executors.Executors
import za.co.absa.hyperdrive.trigger.scheduler.notifications.NotificationSender
import za.co.absa.hyperdrive.trigger.scheduler.sensors.Sensors

import scala.collection.mutable
import scala.collection.concurrent.{Map => ConcurrentMap, TrieMap}
import scala.concurrent.{ExecutionContext, ExecutionContextExecutor, Future}
import scala.util.{Failure, Success}

Expand Down Expand Up @@ -57,7 +57,7 @@ class JobScheduler @Inject() (
private var runningEnqueue = Future.successful((): Unit)
private var runningAssignWorkflows = Future.successful((): Unit)
private var runningSendingNotifications = Future.successful((): Unit)
private val runningDags = mutable.Map.empty[RunningDagsKey, Future[Unit]]
private val runningDags: ConcurrentMap[RunningDagsKey, Future[Unit]] = TrieMap.empty

def startManager(): Unit = {
logger.info("Starting Manager")
Expand Down