Merged
Conversation
build-all.sh header fix
…hecking enhanced
dk1844
commented
Jul 28, 2021
…trolMeasureBuilderTest (+adjusted the to check the usage of `cmb.withSoftware()`)
Zejnilovic
approved these changes
Aug 9, 2021
| } | ||
| } | ||
|
|
||
| object SampleMeasurementsIntegrationSuite { |
Collaborator
There was a problem hiding this comment.
I am unsure if we have an agreement on this or not, but I would rather see this at the top
dk1844
added a commit
that referenced
this pull request
Aug 12, 2021
dk1844
added a commit
that referenced
this pull request
Aug 24, 2021
* #99 examples in a subfolder, * #99 README.md update * #99 encoding added to example projects * #99 span scale factor = 10 for GH action * #99 copyright year update * #99 explicit plugin versions moved to properties (build plugin maven.release.plugin.version, scala.cross.build.maven.plugin.version) * #99 SampleMeasurementsIntegrationSuite companion object moved in front of the class #103 (comment) Co-authored-by: Saša Zejnilović <zejnils@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
SampleMeasurements{1, 2, 3}served a basis for this integration tests._INFOfile content to make the test complete.atum/src/test/resources/data/input/{wikidata.csv, wikidata.csv.info}) are directly copied from theexamplesmoduleControlMeasureBuilderTestcmb.withSoftware(...), too.I haven't created a specific integration profile at this point, because the breadth of the integration code is quite small. Should it grow significantly, we can always proceed with this further.