Skip to content

Profile bio update on already existing and approved profile#279

Merged
timmwille merged 32 commits into
ASKnetCommunity:contentfrom
dutkulang:main
Feb 20, 2023
Merged

Profile bio update on already existing and approved profile#279
timmwille merged 32 commits into
ASKnetCommunity:contentfrom
dutkulang:main

Conversation

@dutkulang

Copy link
Copy Markdown
Contributor

This is an update of all the profiles of already existing experts, the edit was requested by @romeoplat , I would have used the content branch to make the edits but it contains other profiles that are new and need a lot of work. I went with the main branch because the profile are the approved ones

@dutkulang dutkulang requested a review from timmwille February 2, 2023 09:40
@timmwille

Copy link
Copy Markdown
Member

Wow this is a big update, thx @dutkulang though it is hard to track the changes via Issues now, keep in mind to either

  • create a branch per ticket/profile to edit then it is easier to track (optional)
  • send a PR to content branch so we can review/preview first with existing website changes locally and then
  • it really helps if the commit message refers to the respective issue number and maybe close via closes #XYZ (will close when merged into main automatically)

@timmwille timmwille changed the base branch from main to content February 2, 2023 16:38
@dutkulang

Copy link
Copy Markdown
Contributor Author

ok i will create a branch (a copy of main) and push the changes there

@timmwille

Copy link
Copy Markdown
Member

I can see lots of changes in the descriptions but not the entire changes of the Profiles according to Issues (as in contacts, Skillsets etc.) are implemented, so do we leave those issues open and deal with it later to have just a quick update on the profiles? @romeoplat @dutkulang

@timmwille

Copy link
Copy Markdown
Member

I would merge this on content branch but have not yet double checked the images (<1MB and 1:1 or 1:1.5 ratio) @chardso @dutkulang can you confirm?

@chardso

chardso commented Feb 2, 2023

Copy link
Copy Markdown
Contributor

@timmwille that particular image is too large, but however i tried to resize it through telegram share, from 5.8mb to 195.2kb
Unfortunately the image format changes from jpg to jpeg , won't this affect it displaying on the webpage?
If no, i upload the resized one and pullrequest
But before dat i would close the existing pullrequest befote sending another one, is it okay!

@romeoplat

Copy link
Copy Markdown
Contributor

I can see lots of changes in the descriptions but not the entire changes of the Profiles according to Issues (as in contacts, Skillsets etc.) are implemented, so do we leave those issues open and deal with it later to have just a quick update on the profiles? @romeoplat @dutkulang

That's a yes, we still need to actually ad updates on the skills which I guess I want to do, and also we need to be able to reach out to the members to collect their photos
but for lets keep the profiles open.

@timmwille

Copy link
Copy Markdown
Member

Ok then we go step by step, description first. I still think it would be good to keep track of those changes (are all members fine with that change?) here: #280

@timmwille timmwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes will not break the code and add great value to a clear profile collection.

Though @romeoplat @chardso @dawaedina27 @dutkulang

It will also overwrite lots of profile descriptions, so I'm hoping this is sorted out before? will be quite some work to fix this backwards.

@chardso

chardso commented Feb 10, 2023

Copy link
Copy Markdown
Contributor

Will try working on this from my commandline,Incase I find it challenging,I will cry out loud for guidance.

@timmwille

Copy link
Copy Markdown
Member

@chardso also ok if you want to change it back a bit later, as it is not lost, all tracked in the Git History ;)

@timmwille

Copy link
Copy Markdown
Member

@chardso also ok if you want to change it back a bit later, as it is not lost, all tracked in the Git History ;)

I'll merge it now, we can always add improvements/older part back again later from History @chardso

@timmwille timmwille left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve, we still have some work to do though for the linked profile issues as in
#280

@timmwille timmwille merged commit df1dbf7 into ASKnetCommunity:content Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants