Add SWO support for MIMXRT1170-EVK by groleo · Pull Request #712 · ARMmbed/DAPLink

groleo · 2020-05-01T17:52:31Z

This p-r is adding support for NXP's i.MXRT1170-EVK board
and enables SWO for it.

groleo · 2020-05-01T18:53:51Z

cc @flit @maclobdell @marcuschangarm @0xc0170

0xc0170 · 2020-06-02T09:24:20Z

/morph test

0xc0170 · 2020-06-02T09:24:56Z

I'll review this PR today or tomorrow

0xc0170 · 2020-06-03T11:06:20Z

/morph test

0xc0170 · 2020-06-03T11:07:19Z

There's build error:

04:41:15 Building project daplink (lpc4322_mimxrt1170_evk_qspi_if, ARM)
04:41:15 Scan: daplink
04:41:15 Compile [  1.3%]: mimxrt1170_evk.c
04:41:15 Compile [  2.6%]: HardFault_Handler.c
04:41:15 Compile [  3.8%]: circ_buf.c
04:41:15 Compile [  5.1%]: DAP_queue.c
04:41:15 Compile [  6.4%]: JTAG_DP.c
04:41:15 Compile [  7.7%]: SWO.c
04:41:15 [Error] SWO.c@31,27:  #5: cannot open source input file "Driver_USART.h": No such file or directory
04:41:16 [ERROR] ".\source\daplink\cmsis-dap\SWO.c", line 31: Error:  #5: cannot open source input file "Driver_USART.h": No such file or directory
04:41:16   #include "Driver_USART.h"

This issue is related (the last comment): #651 (comment)

0xc0170 · 2020-06-03T11:41:45Z

Can we reuse the files from KL26 or move them as suggested in the issue?

groleo · 2020-06-03T11:42:31Z

There's build error:

fixed. I forgot to add the RTE_Driver files.

groleo · 2020-06-03T11:45:44Z

Can we reuse the files from KL26 or move them as suggested in the issue?

Sure. Let me know where you want to move the Driver_Common.h and Driver_USART.h headers from K26F HIC folder.

I don't know if the RTE_Driver files I've added should also be common.

askyuan · 2020-06-03T11:57:01Z

study

0xc0170 · 2020-06-03T13:44:20Z

/morph test

flit · 2020-06-11T19:13:27Z

source/family/nxp/mimxrt1170_spi_flash/DAP_config.h

+
+/// Indicate that UART Serial Wire Output (SWO) trace is available.
+/// This information is returned by the command \ref DAP_Info as part of <b>Capabilities</b>.
+#define SWO_UART                1               ///< SWO UART:  1 = available, 0 = not available


The DAP_config.h file should be shared between all uses of the LPC4322, not specific to a target. If you want to customize per target, you can wrap this line with #if !defined(SWO_UART), then define that macro in the target project yaml.

flit · 2020-06-11T19:15:12Z

records/board/mimxrt1170_evk_qspi.yaml

+        - source/hic_hal/nxp/lpc4322/RTE_Driver
+        - source/hic_hal/nxp/lpc4322/RTE_Driver/Config
+    sources:
+        lpc4322:
+            - source/hic_hal/nxp/lpc4322/RTE_Driver/USART_LPC43xx.c
+            - source/hic_hal/nxp/lpc4322/RTE_Driver/GPDMA_LPC43xx.c
+            - source/hic_hal/nxp/lpc4322/RTE_Driver/SCU_LPC43xx.c


Please add these sources and includes to the lpc4322.yaml so they are common to all LPC4322 builds. Specifically, we want the generic lpc4322_if project to support SWO.

flit · 2020-06-11T19:21:22Z

Hi @groleo, would you mind removing the RTE_Driver sources that aren't used? To answer your question, these files are specific to the LPC4322, so should stay under that folder.

And yes, please move the Driver_Common.h and Driver_USART.h headers. For now, please place them directly under source/hic_hal/. Or do you think source/cmsis-driver/ would be better?

flit · 2020-06-11T19:22:03Z

cc @mmahadevan108

groleo · 2020-06-11T19:31:34Z

Hi, Got it. I'll move the lpc specific files. If you ask me, it makes sense to have the "Driver_*" under source/cmsis-driver. The files are coming from a sub-directory with the same name, part of a Kyle lpc-link2 sample. I'll push a new p-r tomorow.

…

On Thu, Jun 11, 2020, 10:21 PM Chris Reed ***@***.***> wrote: Hi @groleo <https://github.com/groleo>, would you mind removing the RTE_Driver sources that aren't used? To answer your question, these files are specific to the LPC4322, so should stay under that folder. And yes, please move the Driver_Common.h and Driver_USART.h headers. For now, please place them directly under source/hic_hal/. Or do you think source/cmsis-driver/ would be better? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#712 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAB2RYRTZBMCMOU5FJIQHNLRWEVEBANCNFSM4MXID7KA> .

flit · 2020-06-14T15:50:00Z

You don't need to create a new PR (please don't). Just force push (assuming you even need to) from the same branch, and it will update this PR.

Let's put the CMSIS-Driver headers under source/cmsis-driver as you prefer.

0xc0170 · 2020-06-29T08:42:01Z

/morph test

groleo · 2020-07-03T12:38:33Z

The ci-morph "Details" link is pointing to an internal IP:

 http://10.118.80.30:8080/job/daplink_build_mbedcli_pr/257/

Is there another way I can see what went wrong ?
thx

groleo · 2020-08-10T21:52:37Z

v2: CMSIS-Driver headers under source/cmsis-driver as you prefer.
v3: reorder commits (first reorder the headers, then add platform specific changes)

0xc0170 · 2020-08-11T09:48:31Z

/morph test

groleo · 2020-08-12T18:13:48Z

/morph test

Is there a way to see the CI failures ?

0xc0170 · 2020-08-12T20:31:23Z

It's internal server, I'll find out now

0xc0170 · 2020-08-12T20:32:42Z

10:56:38 Compile [ 50.0%]: SCU_LPC43xx.c
10:56:38 [Error] SCU_LPC43xx.c@33,26:  #5: cannot open source input file "SCU_LPC43xx.h": No such file or directory
10:56:39 [ERROR] ".\source\hic_hal\nxp\lpc4322\RTE_Driver\SCU_LPC43xx.c", line 33: Error:  #5: cannot open source input file "SCU_LPC43xx.h": No such file or directory
10:56:39   #include "SCU_LPC43xx.h"
10:56:39                           ^
10:56:39 .\source\hic_hal\nxp\lpc4322\RTE_Driver\SCU_LPC43xx.c: 0 warnings, 1 error

This is the building error.

flit · 2021-01-06T22:01:36Z

records/board/mimxrt1170_evk_qspi.yaml

+        - SWO_UART=1
+        - SWO_USART_PORT=1


Is there a reason to restrict enabling SWO to only the RT1170-EVK and not enable on all LPC4322 boards? I know the LPCXpresso55S69 has SWO connected to the LPC4322.

the only reason would be that I'm only testing on the RT1170-EVK board.
If you say I can enable SWO for other boards, it's ok with me, I can add a patch for those too.

flit · 2021-01-06T22:03:57Z

source/board/mimxrt1170_evk.c

+ * @brief   board ID for the NXP MIMXRT1170-EVK board.
+ *
+ * DAPLink Interface Firmware
+ * Copyright (c) 2009-2020, ARM Limited, All Rights Reserved


Please change the copyright to your own (or NXP's, as appropriate) for 2020-2021. The same applies to all other new files you added.

fixed as suggested.

flit · 2021-01-06T22:09:12Z

source/daplink/drag-n-drop/flash_manager.c

 static bool buf_empty;
 static bool current_sector_valid;
-static bool page_erase_enabled = false;
+static bool page_erase_enabled = true;


I'm slightly concerned about making this change globally, only because most of the flash algos have not been tested in page erase mode. You can use set the kEnablePageErase flag in the board_info_t struct to set it per board (see frdmk64f.c for an example). It's probably safe to change it globally, but that would better be done in a separate PR.

added kEnablePageErase to source/board/mimxrt1170_evk.c.

flit · 2021-01-06T22:11:25Z

source/family/freescale/target_reset_mimxrt.c

+    #include "target_config.h"
+    extern target_cfg_t target_device ;
+
    if(buf[0] == 'F' && buf[1] == 'C' && buf[2] == 'F' && buf[3] == 'B')
    {
+        target_device.flash_regions[0].start = 0x30000400;
        return 1;
    }
-    else
+    else if(buf[0] == 0xFF && buf[1] == 0xFF && buf[2] == 0xFF && buf[3] == 0xFF)
    {
-        return 0;
+        target_device.flash_regions[0].start = 0x30000000;
+        return 1;
    }
+
+    return 0;


Nice hack! Would you mind adding some comments describing what this code does so we don't forget in the future? 😄

From what I understand, if buf is a FlexSPI Config block (the "FCFB"/0x42464346 test), it moves the flash start address;
but I have no idea what the test against 0xFFFFFFFF part does; I see some other platforms have a "cookieList"

flit

The only changes requested are updating the copyrights, page erase mode default, and possibly enabling SWO on all LPC4322 based boards.

flit · 2021-01-06T22:20:54Z

@groleo My apologies this PR has been outstanding for so long! Honestly I haven't been paying much attention since I've been primarily focused on pyocd.

Signed-off-by: Alex Yang <alex.yang@nxp.com> Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

It provides GetClockFreq() which is needed by USART_LPC43xx.

this provides definitions needed by GetClockFreq()

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

This way, one can set SWO_UART from the target's yaml. Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

mbrossard · 2021-12-06T20:22:09Z

Superseded by #906.

groleo changed the title ~~Add MIMXRT1170-EVK board support~~ Add SWO support for MIMXRT1170-EVK May 5, 2020

groleo force-pushed the master branch from 0e16cb5 to 6817f28 Compare May 5, 2020 09:10

groleo force-pushed the master branch from 6817f28 to bfb9f09 Compare June 3, 2020 11:41

flit reviewed Jun 11, 2020

View reviewed changes

groleo force-pushed the master branch from bfb9f09 to 3124ded Compare June 16, 2020 18:02

groleo requested a review from flit June 16, 2020 18:03

This comment has been minimized.

Sign in to view

groleo force-pushed the master branch from 3124ded to 54dfb52 Compare August 10, 2020 21:50

flit reviewed Jan 6, 2021

View reviewed changes

flit requested changes Jan 6, 2021

View reviewed changes

nxpyandld and others added 16 commits May 20, 2021 21:21

Add MIMXRT1170-EVK board support

f768836

Signed-off-by: Alex Yang <alex.yang@nxp.com> Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

k26f: move Driver_Common.h and Driver_USART.h into source/cmsis-driver

ceff76f

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

lpc4322: update system_LPC43xx

d6c4bf4

It provides GetClockFreq() which is needed by USART_LPC43xx.

lpc4322: update peripheral access layer header file

0840156

this provides definitions needed by GetClockFreq()

lpc4322: add RTE_Driver

bc2eaee

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

lpc4322,DAP_config: define the SWO gpio ports

15aeb98

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

lpc4322: configure the swo gpio port as input

5c8d646

lpc4322,DAP_config: make SWO_UART configurable

6c3739c

This way, one can set SWO_UART from the target's yaml. Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

MIMXRT1170-EVK: enable SWO

8199f2b

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

lpc4322: set the system clock frequency to 120MHz

31278ea

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

lpc4322,DAP_config: increase DAP_PACKET_SIZE and DAP_PACKET_COUNT

7699b59

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

lpc4322,DAP_config: make SWO_STREAM configurable

4046ce3

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

lpc4322,DAP_config: add X_WORD gpio helper

d4e1e87

lpc4322,gpio: use the gpio helpers instead of LPC_GPIO_PORT

d5101fb

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

lpc4322: implement gpio_set_board_power

a322deb

lpc4322: implement LED_CONNECTED_OUT

67e6130

Signed-off-by: Adrian Negreanu <adrian.negreanu@nxp.com>

groleo force-pushed the master branch 2 times, most recently from df0e372 to 67e6130 Compare May 21, 2021 05:56

mathias-arm mentioned this pull request Jun 3, 2021

lpc4322 cleanups for GCC #813

Closed

mbrossard mentioned this pull request Jun 11, 2021

Add SWO support for the k20dx HIC #651

Open

mbrossard mentioned this pull request Dec 6, 2021

Add support for MIMXRT1170-EVK and MIMXRT1060-EVK boards #906

Merged

mbrossard closed this Dec 6, 2021

mathias-arm mentioned this pull request Jun 29, 2022

Not able to Drag-and-Drop with BIN Files #967

Open

Conversation

groleo commented May 1, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

groleo commented May 1, 2020

Uh oh!

0xc0170 commented Jun 2, 2020

Uh oh!

0xc0170 commented Jun 2, 2020

Uh oh!

0xc0170 commented Jun 3, 2020

Uh oh!

0xc0170 commented Jun 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

0xc0170 commented Jun 3, 2020

Uh oh!

groleo commented Jun 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

groleo commented Jun 3, 2020

Uh oh!

askyuan commented Jun 3, 2020

Uh oh!

0xc0170 commented Jun 3, 2020

Uh oh!

flit Jun 11, 2020

Choose a reason for hiding this comment

Uh oh!

flit Jun 11, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flit commented Jun 11, 2020

Uh oh!

flit commented Jun 11, 2020

Uh oh!

groleo commented Jun 11, 2020 via email

Uh oh!

flit commented Jun 14, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

This comment has been minimized.

0xc0170 commented Jun 29, 2020

Uh oh!

groleo commented Jul 3, 2020

Uh oh!

groleo commented Aug 10, 2020

Uh oh!

0xc0170 commented Aug 11, 2020

Uh oh!

groleo commented Aug 12, 2020

Uh oh!

0xc0170 commented Aug 12, 2020

Uh oh!

0xc0170 commented Aug 12, 2020

Uh oh!

flit Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

groleo May 17, 2021

Choose a reason for hiding this comment

Uh oh!

flit Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

groleo May 20, 2021

Choose a reason for hiding this comment

Uh oh!

flit Jan 6, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

groleo May 20, 2021

Choose a reason for hiding this comment

Uh oh!

flit Jan 6, 2021

Choose a reason for hiding this comment

groleo commented May 1, 2020 •

edited

Loading

0xc0170 commented Jun 3, 2020 •

edited

Loading

groleo commented Jun 3, 2020 •

edited

Loading

flit Jun 11, 2020 •

edited

Loading

flit commented Jun 14, 2020 •

edited

Loading

flit Jan 6, 2021 •

edited

Loading

flit Jan 6, 2021 •

edited

Loading

flit Jan 6, 2021 •

edited

Loading