feat: Add NETopKV function. #1251
Open
+1,674
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb2af0c to
1f0778c
Compare
* The Neon(TM) implementation of TopKV reduces execution time from 447.8 ms (scalar CPP) to 11.65 ms for the same workload (F32, C=1000, N=32000, k=3, 6 threads), achieving an approximate 38× speedup. This gain comes from SIMD vectorization, removal of per-element branches, and a more efficient inner loop. * Resolves ARMCL-1227 Change-Id: Ifdf161ce4254dc5ecd57aff9ae22410facd31705 Signed-off-by: Pablo Marquez Tello <[email protected]>
gunes-arm
requested changes
Jan 16, 2026
| * @publicapi | ||
| */ | ||
|
|
||
| #include "arm_compute/core/Types.h" |
Contributor
There was a problem hiding this comment.
Which types are needed from this file?
| */ | ||
| void configure(const ITensor *predictions, const ITensor *targets, ITensor *output, const unsigned int k); | ||
|
|
||
| /** Static function to check if given info will lead to a valid configuration of @ref CPPTopKVKernel |
| #include "src/core/helpers/WindowHelpers.h" | ||
| #include "src/cpu/kernels/topkv/list.h" | ||
|
|
||
| #include <array> |
Contributor
There was a problem hiding this comment.
vector? also we need to add cstdint
| void | ||
| configure(const ITensorInfo *predictions, const ITensorInfo *targets, ITensorInfo *output, const unsigned int k); | ||
|
|
||
| /** Static function to check if given info will lead to a valid configuration of @ref CPPTopKVKernel |
Contributor
There was a problem hiding this comment.
can we just say "similar to @ref CpuTopKV::configure()" to reduce duplication? Have a look at arm_compute/runtime/experimental/operators/CpuActivation.h
Same comment is valid for every header
| ARM_COMPUTE_TRACE_EVENT(ARM_COMPUTE_PROF_CAT_CPU, ARM_COMPUTE_PROF_LVL_CPU, "CpuTopKV::run"); | ||
| ARM_COMPUTE_ERROR_ON_MSG(tensors.empty(), "No inputs provided"); | ||
|
|
||
| NEScheduler::get().schedule_op(_kernel.get(), 0, _kernel->window(), tensors); |
Contributor
There was a problem hiding this comment.
instead of 0, we use Window::DimX
| *reinterpret_cast<const T *>(predictions(Coordinates{static_cast<int>(c), static_cast<int>(i)})); | ||
| const float v = static_cast<float>(vt); | ||
|
|
||
| // Mirror CPPTopKVKernel: (a - b > epsilon) |
| { | ||
|
|
||
| template <typename T> | ||
| SimpleTensor<uint8_t> topkv(SimpleTensor<T> &predictions, SimpleTensor<uint32_t> &targets, uint32_t k) |
Contributor
There was a problem hiding this comment.
I think we need to include
- SimpleTensor.h
- TensorShape.h
- cstdint (because of int types)
- CoreTypes.h for DataType
- Coordinates.h
Anything else? We don't need the big Types.h file
| #include "tests/IAccessor.h" | ||
| #include "tests/validation/Helpers.h" | ||
| #include "tests/validation/reference/TopKV.h" | ||
|
|
Contributor
There was a problem hiding this comment.
I think we need to include cstdint, type_traits, random and algorithm STL headers for the functions used here.
| #include "tests/AssetsLibrary.h" | ||
| #include "tests/framework/Asserts.h" | ||
| #include "tests/framework/Fixture.h" | ||
| #include "tests/framework/ParametersLibrary.h" |
Contributor
There was a problem hiding this comment.
Do we need
- ParametersLibrary.h
- IAccessor.h
- tests/validation/Helpers.h
| #define ACL_TESTS_VALIDATION_FIXTURES_TOPKVLAYERFIXTURE_H | ||
|
|
||
| #include "arm_compute/core/TensorShape.h" | ||
| #include "arm_compute/core/Types.h" |
Contributor
There was a problem hiding this comment.
Do we need anything particular from this file?
1f0778c to
cb1481c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Neon(TM) implementation of TopKV reduces execution time from 447.8 ms (scalar CPP) to 11.65 ms for the same workload (F32, C=1000, N=32000, k=3, 6 threads), achieving an approximate 38× speedup. This gain comes from SIMD vectorization, removal of per-element branches, and a more efficient inner loop.
Resolves ARMCL-1227
Change-Id: Ifdf161ce4254dc5ecd57aff9ae22410facd31705