fixed screen-mirror: reverted coderabbit suggestion

[imxade]

Summary by CodeRabbit

• Refactor
  • Improved WebSocket connection management and relay mechanisms for enhanced stability and efficiency.

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between aec05cc and 68adb15.

📒 Files selected for processing (1)

• src/server/websocket.ts

---

Walkthrough

The WebSocket connection handler removes per-connection in-memory consumer Set tracking and switches to iterating over the global WebSocketServer client list with filtering. The "stop-provider" message handler is removed, mirror lifecycle logic is simplified, and the close event message is updated.

Changes

Cohort / File(s)	Summary
WebSocket Consumer Tracking Refactor src/server/websocket.ts	Removed per-connection consumer Set tracking; broadcasts now filter across global wss.clients list. Eliminated stop-provider message handling and updated mirror lifecycle to set isConsumer state directly. Updated close event message text.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

• feat: implement optimized native browser API screen mirroring #212: Adds consumer Set and mirror/provider message logic that this PR refactors by removing the Set and consolidating the broadcast approach.

Suggested labels

Typescript Lang

Poem

🐰 A rabbit nibbled through the code with care,
Removing Sets that cluttered consumer air,
Now global filters dance where locals were,
Stop-provider whispers fade without a stir,
Simpler streams through cleaner pathways fair!

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}