Skip to content

fix(collector): remove inert AddQylAspNetCoreInstrumentation + dishonest comment (CODE RED) - #461

Merged
ANcpLua merged 1 commit into
mainfrom
claude/codered-collector-telemetry
Jul 1, 2026
Merged

fix(collector): remove inert AddQylAspNetCoreInstrumentation + dishonest comment (CODE RED)#461
ANcpLua merged 1 commit into
mainfrom
claude/codered-collector-telemetry

Conversation

@ANcpLua

@ANcpLua ANcpLua commented Jul 1, 2026

Copy link
Copy Markdown
Owner

CODE RED finding #5 (HIGH, mine): the 4.0.0 cutover added builder.Services.AddQylAspNetCoreInstrumentation() with a comment claiming it wires the server-request span. It doesn'tQylActivitySource ("Qyl.OpenTelemetry.AutoInstrumentation") is AddSource'd on no TracerProvider in the collector (grep = 0 hits), so StartActivity returns null and the middleware emits zero spans. The collector's real SERVER/CLIENT spans come from built-in AddAspNetCoreInstrumentation + AddHttpClientInstrumentation (OTel-conformant, carry http.route).

Removes the dead call + false comment + now-unused using. No telemetry lost. Collector Release builds 0/0.

🤖 Generated with Claude Code

…est comment (CODE RED #5)

The 4.0.0 cutover added builder.Services.AddQylAspNetCoreInstrumentation() with a comment
claiming it wires the server-request span. It does not: QylActivitySource
("Qyl.OpenTelemetry.AutoInstrumentation") is AddSource'd on NO TracerProvider in the
collector (grep = 0 hits), so QylActivitySource.StartActivity returns null and the
IStartupFilter middleware emits ZERO spans. The collector's real SERVER/CLIENT spans come
from built-in AddAspNetCoreInstrumentation + AddHttpClientInstrumentation
(QylServiceDefaultsExtensions.cs:194-200), which are OTel-conformant and carry http.route.

Remove the dead call + false comment + now-unused using. No telemetry lost (the call
produced none). Collector Release builds 0/0.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Copilot AI review requested due to automatic review settings July 1, 2026 14:35
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (1)
  • services/qyl.collector/Program.cs is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2d36e051-e75d-4637-9fd6-a52a454b1827

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@github-actions
github-actions Bot enabled auto-merge (squash) July 1, 2026 14:35
@ANcpLua
ANcpLua merged commit d4c8682 into main Jul 1, 2026
7 checks passed
@ANcpLua
ANcpLua deleted the claude/codered-collector-telemetry branch July 1, 2026 14:36

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes a collector startup registration and comment that implied qyl’s custom ASP.NET Core “server-request span” middleware was responsible for request spans, when the collector’s actual tracing is already provided via OpenTelemetry’s AddAspNetCoreInstrumentation / AddHttpClientInstrumentation configured in ServiceDefaults.

Changes:

  • Remove builder.Services.AddQylAspNetCoreInstrumentation() from the collector startup pipeline.
  • Remove the accompanying comment and now-unused using Qyl.OpenTelemetry.AutoInstrumentation;.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants