fix(collector): remove inert AddQylAspNetCoreInstrumentation + dishonest comment (CODE RED) - #461
Conversation
…est comment (CODE RED #5) The 4.0.0 cutover added builder.Services.AddQylAspNetCoreInstrumentation() with a comment claiming it wires the server-request span. It does not: QylActivitySource ("Qyl.OpenTelemetry.AutoInstrumentation") is AddSource'd on NO TracerProvider in the collector (grep = 0 hits), so QylActivitySource.StartActivity returns null and the IStartupFilter middleware emits ZERO spans. The collector's real SERVER/CLIENT spans come from built-in AddAspNetCoreInstrumentation + AddHttpClientInstrumentation (QylServiceDefaultsExtensions.cs:194-200), which are OTel-conformant and carry http.route. Remove the dead call + false comment + now-unused using. No telemetry lost (the call produced none). Collector Release builds 0/0. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (1)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
There was a problem hiding this comment.
Pull request overview
Removes a collector startup registration and comment that implied qyl’s custom ASP.NET Core “server-request span” middleware was responsible for request spans, when the collector’s actual tracing is already provided via OpenTelemetry’s AddAspNetCoreInstrumentation / AddHttpClientInstrumentation configured in ServiceDefaults.
Changes:
- Remove
builder.Services.AddQylAspNetCoreInstrumentation()from the collector startup pipeline. - Remove the accompanying comment and now-unused
using Qyl.OpenTelemetry.AutoInstrumentation;.
CODE RED finding #5 (HIGH, mine): the 4.0.0 cutover added
builder.Services.AddQylAspNetCoreInstrumentation()with a comment claiming it wires the server-request span. It doesn't —QylActivitySource("Qyl.OpenTelemetry.AutoInstrumentation") isAddSource'd on no TracerProvider in the collector (grep = 0 hits), soStartActivityreturns null and the middleware emits zero spans. The collector's real SERVER/CLIENT spans come from built-inAddAspNetCoreInstrumentation+AddHttpClientInstrumentation(OTel-conformant, carryhttp.route).Removes the dead call + false comment + now-unused using. No telemetry lost. Collector Release builds 0/0.
🤖 Generated with Claude Code