QoL Improvements in Search#159
Merged
Merged
Conversation
* Massively faster incremental search by highlighting only the visible lines * Full buffer is only highlighted once the search query is confirmed * All searches (including incremental previews) now wrap around to the opposite direction when no match found
* fix incremental previe not being cleared when search is cancelled * fix upper mark is reset if search is confirmed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to improve the search system by introducing quality-of-life improvements, performance enhancements, and refactoring.
Here's the quick changelist for the PR: